Fix duplicate activity cancellation commands - #1814
Open
tconley1428 wants to merge 1 commit into
Open
Conversation
THardy98
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1813.
When workflow cancellation and an explicit activity-handle cancellation reach the same activity task, emit one cancellation command per activity sequence. Command allocation now occurs in cancellation callbacks, allowing the activity path to suppress duplicates without producing an empty command.
Adds a regression test that queues the signal and workflow cancellation while the workflow worker is offline, verifies they are delivered in one activation, and asserts the workflow completes without failed workflow tasks.
Validation:
poe test -s tests/worker/test_workflow.py::test_workflow_cancel_activity_while_workflow_cancelledpoe lint