[SDK Sentinel] Wait for Nexus update workflow closure - #1810
Open
sdk-sentinel-bot wants to merge 1 commit into
Open
Conversation
tconley1428
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
This PR contains untrusted AI-generated code. Do not approve or run CI until a maintainer has reviewed the diff. SDK Sentinel verified that GitHub Actions remained approval-gated with zero executable jobs when this PR was opened.
Summary
Prevent an intermittent timeout in the Nexus update-workflow test seen on [Linux ARM](https://github.com/temporalio/sdk-python/actions/runs/33571900335/job/100067454366) and [macOS ARM](https://github.com/temporalio/sdk-python/actions/runs/33565770243/job/100048472237). The bounded window has no preceding equivalent success; the [earliest captured matching failure](https://github.com/temporalio/sdk-python/actions/runs/33528432659) was followed by repeated target-branch failures.
Root cause
The test treated completion of the final update as proof that the target workflow had closed. Those events are not synchronized, so the next update could race workflow closure and remain pending until pytest's 60-second timeout.
Fix
Await the target workflow result before issuing the update whose expected behavior depends on the workflow already being closed.
Validation
The unchanged test did not reproduce in three local repetitions. After the change, ten stress repetitions passed. The fixed repository validator also passed using the preloaded Rust toolchain. Linux ARM and macOS ARM CI remain required because local validation ran on Linux x64.
Validation status:
validated-without-reproductionhighhighhighstandard— 1 changed file; 683 Bnot-reproduced— The unchanged exact test passed three local stress repetitions.pass-after-only— The existing exact test passed ten stress repetitions after adding explicit workflow-closure synchronization.Poe lint, bridge lint, and editable build) — passedPoe lint, bridge lint, and editable build) — passedInvestigator-run checks
poe test -s tests/nexus/test_temporal_operation.py::test_temporal_operation_update_workflow --flake-finder --flake-runs=3— passed; 1 attempt(s). The unchanged test passed three repetitions; natural reproduction was not observed.poe test -s tests/nexus/test_temporal_operation.py::test_temporal_operation_update_workflow --flake-finder --flake-runs=10— passed; 1 attempt(s). All ten post-change repetitions passed..ci-flake-runtime/input/validate.sh— failed; 1 attempt(s). Lint and type checks passed, but the isolated cache lacked a configured Rust toolchain.RUSTUP_HOME=/home/runner/.rustup .ci-flake-runtime/input/validate.sh— passed; 1 attempt(s). The canonical validator passed using the preloaded system Rust toolchain.Required target CI
Residual risks
Automation provenance
d0e075c1e25b3371f0e0f5116d9c6626892e3eabIf this finding should not be fixed, apply the
sdk-sentinel:false-positivelabel and close the PR. Sentinel will suppress the finding until its affected source changes.SDK Sentinel recurrence history
2026-09-01 23:51 UTC2026-09-01 23:51 UTC