-
Notifications
You must be signed in to change notification settings - Fork 243
Implement operator commands for Standalone Activities #3013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GregoryTravis
wants to merge
65
commits into
main
Choose a base branch
from
gmt/operator-commands
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
34a1350
wip
GregoryTravis c9114e4
Merge branch 'master' into gmt/operator-commands
GregoryTravis 0e3094c
wip
GregoryTravis d5a73ee
wip
GregoryTravis 3b4d6ce
Merge branch 'master' into gmt/operator-commands
GregoryTravis 9d99a8e
wip
GregoryTravis 68d48ca
wip
GregoryTravis 8c4e9ac
Consistent test naming
GregoryTravis fde3769
Extra assertions
GregoryTravis bf9526f
Redundant test
GregoryTravis c80837b
Merge tag 'master' into gmt/operator-commands
GregoryTravis 8b1fbf9
Task queue update fix
GregoryTravis cfb1828
Update server deps
GregoryTravis ba78468
Fix heartbeat tests
GregoryTravis 6fc294d
Confirm UpdateOptions surface handles start_delay
GregoryTravis b7d94ec
upstream update
GregoryTravis a4e6483
upstream update
GregoryTravis 57482d9
Merge branch 'main' into gmt/operator-commands
GregoryTravis fd866af
Use CancellationToken
GregoryTravis d6d6155
Merge branch 'main' into gmt/operator-commands
GregoryTravis c5ddde1
test: update options requires at least one option
GregoryTravis 67677cd
test_update_options_on_paused_activity
GregoryTravis d2eccb2
Round out implementation of four payload details fields, default false.
GregoryTravis ea3efac
getInput/Result
GregoryTravis a5e67d7
Experimental
GregoryTravis cdc0587
Merge branch 'main' into gmt/operator-commands
GregoryTravis 37d6d1a
Revert scheduleTime change
GregoryTravis 7c690fc
DescribeActivityOptions
GregoryTravis 8ed0212
- ActivityExecutionDescription: drop the redundant `info` field and r…
GregoryTravis eec348c
Fix DescribeActivityInput call site in temporal-opentracing tests
GregoryTravis 550edb3
Add a describe paused-status test
GregoryTravis 135c6a3
Reject an updateOptions call that sets no options
GregoryTravis eb3e02c
Remove reset/heartbeat tests
GregoryTravis 972ed0f
Merge branch 'main' into gmt/operator-commands
GregoryTravis 8f4b443
Add total_heartbeat_count and test
GregoryTravis b251674
Update server release version
GregoryTravis 628b866
fix docstring
GregoryTravis 092461c
Assert every reset flag reaches the request
GregoryTravis 3a20112
Replace three describe tests with one describePayloads
GregoryTravis baef99a
Unit-test that the describe opt-ins reach the request
GregoryTravis 743ef90
Unit-test that unrequested payloads are stripped client-side
GregoryTravis c69c9a4
Remove updateOptionsAcceptsASingleOption as redundant
GregoryTravis f24d4e6
Test that restore-original routes through the update interceptor
GregoryTravis c3831d0
remove non-pr files
GregoryTravis b499934
cleanup
GregoryTravis e3404b3
remove describeOptInsReachTheRequest tests
GregoryTravis 2f29374
cleanup
GregoryTravis 6de983c
remove test_restore_original_options_routes_through_update
GregoryTravis 9f0b153
Test clearing an option with a zero duration
GregoryTravis f208804
Model update activity options on sdk precedent
GregoryTravis 5a476ea
cleanup
GregoryTravis d429cef
Remove mocked id checks
GregoryTravis 1a2ba38
Remove long start delay wait
GregoryTravis 4007277
start delayed in restore test
GregoryTravis 98f668f
missing files
GregoryTravis d864113
cleanup
GregoryTravis 998e430
Merge branch 'main' into gmt/operator-commands
GregoryTravis dfaf027
Add CHANGELOG.md
GregoryTravis 776709b
Merge branch 'main' into gmt/operator-commands
GregoryTravis 451153e
Fix javadoc
GregoryTravis e13ba47
Do not remove unrequested optional describe payloads
GregoryTravis 00222f7
Add test_interceptor_receives_command_arguments, include inputs in Re…
GregoryTravis 80b1122
remove reset
GregoryTravis 0d22c0d
remove reset
GregoryTravis bb8ebc5
remove reset
GregoryTravis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| <!-- | ||
| High-level release notes. | ||
| Loosely based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). | ||
|
|
||
| When your PR includes a user-facing change, add an entry below under the | ||
| appropriate heading (create the heading if it does not yet exist). Within | ||
| each heading content can be free-form. Feel free to include examples, links | ||
| to docs, or any other relevant information. | ||
|
|
||
| ### Added — new features | ||
| ### Changed — changes in existing functionality | ||
| ### Deprecated — soon-to-be-removed features | ||
| ### :boom: Breaking Changes — removed or backwards-incompatible features | ||
| ### Fixed — notable bug fixes | ||
| ### Security — notable security fixes | ||
| --> | ||
|
|
||
| # Changelog | ||
|
|
||
| ## [Unreleased] | ||
|
|
||
| ### Added | ||
|
|
||
| #### Standalone Activity operator commands | ||
|
|
||
| - `UntypedActivityHandle` and `ActivityHandle` now support operator commands for standalone | ||
| activities: `pause()`, `unpause()`, `updateOptions()` and `restoreOriginalOptions()`. | ||
| `updateOptions()` takes `ActivityOptionsUpdate` values built from the keys on | ||
| `ActivityOptionsKeys`, via `ActivityOptionsKey.valueSet()` to set an option or | ||
| `ActivityOptionsKey.valueUnset()` to clear it, and returns the server's resolved | ||
| `ActivityExecutionOptions`. | ||
| - Added opt-in payload flags to `DescribeActivityOptions`: `setIncludeInput()`, | ||
| `setIncludeOutcome()`, `setIncludeHeartbeatDetails()` and `setIncludeLastFailure()`, all | ||
| defaulting to `false`. | ||
| - Added missing `ActivityExecutionDescription` fields: `getExecutionTime()`, `getStartDelay()` | ||
| and `getTotalHeartbeatCount()`. | ||
|
|
||
| ### :boom: Breaking Changes | ||
|
|
||
| - `ActivityExecutionDescription` payload fields are now opt-in and must be requested via | ||
| `DescribeActivityOptions`: `getInput()`, `getResult()`, `getHeartbeatDetails()` and | ||
| `getLastFailure()`. Each has a matching `hasInput()` / `hasResult()` / | ||
| `hasHeartbeatDetails()` / `hasLastFailure()` predicate. | ||
|
|
||
| ### Changed | ||
|
|
||
| ### Deprecated | ||
|
|
||
| ### Fixed | ||
|
|
||
| ### Security |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Java SDK hasn't adopted the CHANGELOG.md file yet. Remove this.