fix: drop net48 target to fix Windows build with SourceGear.sqlite3 - #7
Merged
Merged
Conversation
SourceGear.sqlite3's .NET Framework props reject AnyCPU builds
("This package does not support Any CPU builds"), failing the Windows CI on the
net48 target. Drop net48 and target netstandard2.0 only: it is consumable by
.NET Framework 4.6.1+ and modern .NET alike, and the published package (built on
Linux) never contained a net48 assembly anyway, so this also makes the build
consistent across operating systems. Document the .NET Framework PlatformTarget
requirement for downstream consumers in the README.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017xW2zhMvrJChpY58hfJBeZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows CI fails on the
net48target because SourceGear.sqlite3's .NET Framework props reject AnyCPU builds (This package does not support Any CPU builds).Fix by targeting netstandard2.0 only, which is consumable by .NET Framework 4.6.1+ and modern .NET alike. The published package (built on Linux) never contained a net48 assembly anyway, so this also makes the build consistent across all three CI operating systems. Adds a README note documenting the
<PlatformTarget>requirement for .NET Framework consumers.