ci: fix NU5026 pack failure and modernise CI to .NET 8/9 - #6
Merged
Merged
Conversation
Remove GeneratePackageOnBuild from the library project: combined with an
explicit `dotnet pack -o artifacts` it races the build output and fails with
NU5026 ("file to be packed was not found"), which broke the publish workflow.
Packaging is now driven solely by the explicit `dotnet pack`. This also stops
the library being re-packed (and emitting readme warnings) during `dotnet test`.
Update the CI workflow to .NET 8.0.x + 9.0.x (was 6.0.x, which can't build the
net8.0 test project) and bump checkout/setup-dotnet to v4.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017xW2zhMvrJChpY58hfJBeZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
dotnet packNU5026 failure in the publish workflow by removingGeneratePackageOnBuildfrom the library project (it races the explicitdotnet pack -o artifactsbuild output). Packaging is now driven solely by the explicit pack step; this also stops the lib being re-packed duringdotnet test.Also modernises the CI workflow: .NET
8.0.x+9.0.x(was6.0.x, which can't build the net8.0 test project) and bumpsactions/checkout/setup-dotnetto v4.