Skip to content

Updated derivation with improved numerical stability - #1180

Merged
NimaSarajpoor merged 5 commits into
stumpy-dev:mainfrom
seanlaw:updated_matrix_profile_derivation
Aug 25, 2026
Merged

Updated derivation with improved numerical stability#1180
NimaSarajpoor merged 5 commits into
stumpy-dev:mainfrom
seanlaw:updated_matrix_profile_derivation

Conversation

@seanlaw

@seanlaw seanlaw commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Pull Request Checklist

Below is a simple checklist but please do not hesitate to ask for assistance!

  • Read our Contributing Guide
  • Referenced a Github issue (or create one if one doesn't already exist)
  • Read and reviewed all of the comments in the Github issue that you've referenced (along with cross-referenced issues/pull requests) to ensure that the issue still requires a pull request
  • Checked that the issue has not already been assigned to anybody else or is already being addressed in another pull request
  • Left a meaningful comment on the original Github issue to discuss the detailed approach for your contribution and received confirmation from the maintainers before proceeding with this pull request
  • Forked, cloned, and checked out the newest version of the code
  • Created a new branch
  • Made necessary code changes
  • Installed black (i.e., python -m pip install black or conda install -c conda-forge black)
  • Installed flake8 (i.e., python -m pip install flake8 or conda install -c conda-forge flake8)
  • Installed pytest-cov (i.e., python -m pip install pytest-cov or conda install -c conda-forge pytest-cov)
  • Ran black --exclude=".*\.ipynb" --extend-exclude=".venv" --diff ./ in the root stumpy directory
  • Ran flake8 --extend-exclude=.venv ./ in the root stumpy directory
  • Ran ./setup.sh dev && ./test.sh in the root stumpy directory and ensured that all tests are passing locally
  • Check this box if AI code assistance was used to generate 15%+ of the code in this pull request

Please do not commit any code to avoid/circumvent a failing test and, instead, engage in a discussion (below) to determine the best course of action.

Only request a review after the checklist above is fully completed!

@gitnotebooks

gitnotebooks Bot commented Aug 12, 2026

Copy link
Copy Markdown

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1180

@seanlaw
seanlaw requested a review from NimaSarajpoor August 12, 2026 00:51
@seanlaw

seanlaw commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

@NimaSarajpoor Would you mind taking a look when you have some time? Thanks in advance!

You may need to download the file in order to get the LaTex to render properly

@NimaSarajpoor NimaSarajpoor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanlaw
It was great to see all the steps involved in deriving equation (91). Thanks for putting them together so clearly! I have shared a few comments for your consideration.

Comment thread docs/REF/Matrix_Profile_Derivation.ipynb Outdated
Comment thread docs/REF/Matrix_Profile_Derivation.ipynb Outdated
Comment thread docs/REF/Matrix_Profile_Derivation.ipynb Outdated
Comment thread docs/REF/Matrix_Profile_Derivation.ipynb
Comment thread docs/REF/Matrix_Profile_Derivation.ipynb
Comment thread docs/REF/Matrix_Profile_Derivation.ipynb
@seanlaw

seanlaw commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@NimaSarajpoor I think the notebook is ready to be merged now. Let me know if you see anything that needs to change

@NimaSarajpoor

Copy link
Copy Markdown
Collaborator

@seanlaw
All good.... and Merged!

@NimaSarajpoor
NimaSarajpoor merged commit 4241802 into stumpy-dev:main Aug 25, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants