Repository navigation
Fix aiohttp buffered response body error handling 🪿✨ - #2000
Draft
jar-stripe wants to merge 2 commits into
Draft
jar-stripe wants to merge 2 commits into
jar-stripe wants to merge 2 commits into
Conversation
Committed-By-Agent: goose Orbit-Session-Id: 5fb90387-7427-4606-8a20-d00aea91367b
Simplify regression-test setup by replacing the async error helper with distinct exception instances, removing an unused partial-body value, and wrapping the existing successful reader rather than duplicating its return value. These changes remove redundant setup without altering production behavior or assertions for retry counts, exception causes, recovery, and cancellation. All 31 aiohttp tests passed. Targeted formatting and git diff --check also passed. Committed-By-Agent: goose Orbit-Session-Id: 5fb90387-7427-4606-8a20-d00aea91367b
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Buffered aiohttp response-body failures escape as raw exceptions and bypass
max_network_retries.What?
Route buffered body-read failures through the existing error handler to raise retryable
APIConnectionErrors with preserved causes. Add regression coverage for payload errors, timeouts, exact retry budgets, recovery, and cancellation, plus a patch changefile. Explicit streaming behavior remains unchanged.See Also
Fixes #1993
Configuration
skip-changefile: This PR is not a user-facing change, so there's no changefile.