Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
title: "Encode `bool` and `datetime` elements of list parameters the same way as top-level values (`true`/`false` and unix timestamps) instead of sending Python's `str()` form"
semver_level: patch
---
4 changes: 4 additions & 0 deletions stripe/_encode.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,10 @@ def _api_encode(
)
for k, v in _api_encode(subdict):
yield (k, v)
elif isinstance(sv, datetime.datetime):
yield (encoded_key, _encode_datetime(sv))
elif isinstance(sv, bool):
yield (encoded_key, str(sv).lower())
else:
yield (encoded_key, sv)
elif isinstance(value, dict) or hasattr(value, "_data"):
Expand Down
14 changes: 14 additions & 0 deletions tests/test_encode.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import datetime
import warnings

from stripe._stripe_object import StripeObject
Expand Down Expand Up @@ -86,6 +87,19 @@ def test_encode_boolean_value(self):
result = list(_api_encode({"active": True, "deleted": False}))
assert result == [("active", "true"), ("deleted", "false")]

def test_encode_list_with_boolean_values(self):
"""Booleans inside a list are encoded as lowercase strings, like top-level booleans."""
result = list(_api_encode({"flags": [True, False]}))
assert result == [("flags[0]", "true"), ("flags[1]", "false")]

def test_encode_list_with_datetime_values(self):
"""Datetimes inside a list are encoded as unix timestamps, like top-level datetimes."""
dt = datetime.datetime(
2024, 1, 2, 3, 4, 5, tzinfo=datetime.timezone.utc
)
result = list(_api_encode({"created": [dt]}))
assert result == [("created[0]", 1704164645)]

def test_encode_list_value(self):
"""Test that list values are encoded with indexed keys."""
result = list(_api_encode({"items": ["item1", "item2", "item3"]}))
Expand Down