Skip to content

Reject blank webhook secrets 🪿✨ - #1940

Merged
zacchua-stripe merged 5 commits into
masterfrom
reject-blank-webhook-secrets
Oct 20, 2026
Merged

zacchua-stripe merged 5 commits into
masterfrom
reject-blank-webhook-secrets

Conversation

@zacchua-stripe

Copy link
Copy Markdown
Contributor

Why?

Reject webhook secrets made entirely of ASCII whitespace so invalid configuration fails with the existing missing-secret errors instead of reaching HMAC verification.

What?

  • Webhook signature verification and StripeEventNotificationHandler now treat space, tab, CR, LF, form feed, and vertical tab-only values as blank while preserving nonblank secrets.

See Also

http://go/j/RUN_DEVSDK-3378

Configuration

  • skip-changefile: This PR is not a user-facing change, so there's no changefile.

Committed-By-Agent: goose
Orbit-Session-Id: a8a3ff0b-2818-4677-9877-6974eda81782
@zacchua-stripe
zacchua-stripe requested a review from a team as a code owner October 2, 2026 23:28
@zacchua-stripe
zacchua-stripe requested review from jar-stripe and removed request for a team October 2, 2026 23:28
@zacchua-stripe
zacchua-stripe marked this pull request as draft October 2, 2026 23:29
Committed-By-Agent: codex
Co-authored-by: codex <noreply@openai.com>
Comment thread tests/test_v2_event.py Resolved
Comment thread tests/test_webhook.py Resolved
Committed-By-Agent: codex
Co-authored-by: codex <noreply@openai.com>
@zacchua-stripe
zacchua-stripe marked this pull request as ready for review October 6, 2026 22:12
@zacchua-stripe
zacchua-stripe enabled auto-merge (squash) October 19, 2026 19:22
@zacchua-stripe
zacchua-stripe merged commit 89e8528 into master Oct 20, 2026
19 checks passed
@zacchua-stripe
zacchua-stripe deleted the reject-blank-webhook-secrets branch October 20, 2026 00:03
zacchua-stripe added a commit that referenced this pull request Oct 29, 2026
* Update generated code for v2526 and 588801ef34f7b5f7d6a784d3354f5f93d2a26ffb

* Add v16 migration guidance links (#1935)

* Bump version to 16.0.0

* Add API v2 Search support (#1939)

* Add API v2 search result pagination

Committed-By-Agent: goose
Orbit-Session-Id: ac7fd08a-e385-4498-800e-21f51d3e4ad6

* Send v2 Search limit as a query parameter

Committed-By-Agent: goose
Orbit-Session-Id: ac7fd08a-e385-4498-800e-21f51d3e4ad6

* Preserve v2 Search page URLs

Committed-By-Agent: goose
Orbit-Session-Id: ac7fd08a-e385-4498-800e-21f51d3e4ad6

* Add v2 Search changefile

Committed-By-Agent: goose
Orbit-Session-Id: ac7fd08a-e385-4498-800e-21f51d3e4ad6

* Refine v2 Search changefile

Committed-By-Agent: goose
Orbit-Session-Id: ac7fd08a-e385-4498-800e-21f51d3e4ad6

* Restore v2 Search change title

Committed-By-Agent: goose
Orbit-Session-Id: ac7fd08a-e385-4498-800e-21f51d3e4ad6

* Refine auto-pagination change wording

Committed-By-Agent: goose
Orbit-Session-Id: ac7fd08a-e385-4498-800e-21f51d3e4ad6

* fixed tests and ran just prepare

* Make Stripe errors serializable (#1944)

* Make Stripe errors serializable

Committed-By-Agent: codex
Co-authored-by: codex <noreply@openai.com>

* Add serialization fix changefile

Committed-By-Agent: codex
Co-authored-by: codex <noreply@openai.com>

---------

Co-authored-by: codex <noreply@openai.com>

* Reject blank webhook secrets 🪿✨ (#1940)

* Reject blank webhook secrets

Committed-By-Agent: goose
Orbit-Session-Id: a8a3ff0b-2818-4677-9877-6974eda81782

* Add blank webhook secret changefile

Committed-By-Agent: codex
Co-authored-by: codex <noreply@openai.com>

* Clarify missing webhook secret tests

Committed-By-Agent: codex
Co-authored-by: codex <noreply@openai.com>

---------

Co-authored-by: codex <noreply@openai.com>

* Update certificate bundle included in SDK (#1955)

* updated the certificate bundle

* added changefile

* Correct changelog entry

Point to the TLS certificates docs instead of the PEM file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Committed-By-Agent: claude

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* Preserve event context on fetched related objects (#1957)

* Preserve event context on fetched objects

Committed-By-Agent: codex
Co-authored-by: codex <noreply@openai.com>

* Add event context changefile

Committed-By-Agent: codex
Co-authored-by: codex <noreply@openai.com>

---------

Co-authored-by: codex <noreply@openai.com>

---------

Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>
Co-authored-by: jar-stripe <jar@stripe.com>
Co-authored-by: zacchua-stripe <zacchua@stripe.com>
Co-authored-by: codex <noreply@openai.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants