Repository navigation
Make v2 search limit hoisting explicit - #2324
Merged
Merged
Conversation
Committed-By-Agent: goose Orbit-Session-Id: bf0045b8-bfc9-4e18-ae11-5f042ce9add7
Committed-By-Agent: goose Orbit-Session-Id: bf0045b8-bfc9-4e18-ae11-5f042ce9add7
jar-stripe
marked this pull request as ready for review
November 2, 2026 16:50
jar-stripe
requested review from
a team,
mark-kogan-stripe and
mnorth-stripe
and removed request for
a team and
mnorth-stripe
November 2, 2026 16:50
Committed-By-Agent: goose Orbit-Session-Id: bf0045b8-bfc9-4e18-ae11-5f042ce9add7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
ApiService#request has special handling for v2 search methods. This handling is invoked when a POST method has a path that starts with /v2 and ends with search, but that is also a valid pattern for v2 custom operations. Our code generator needs to be able to generate code that adequately distinguishes between the two types of methods.
What?
ApiRequestconstructor; no boolean overload or per-request flag.ApiService.requestV2Search(ApiRequest, Type), copying and preparing URL/body before exactly one ordinary request delegation.limitfrom params if present and remove it from the copied body. Pagination uses ordinary requests, preserving server-authored page URLs.Validation:
just testandjust format-checkpass, includingStripeSearchResultTest.See Also
Configuration
skip-changefile: This PR is not a user-facing change, so there's no changefile.