Add stellar token symbol subcommand - #2712
Open
fnando wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds stellar token symbol for querying SEP-41 symbol metadata.
Changes:
- Adds read-only symbol invocation with text/JSON output.
- Integrates command routing and structured errors.
- Adds help documentation and integration tests.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
FULL_HELP_DOCS.md |
Documents the symbol command. |
cmd/soroban-cli/src/commands/token/symbol.rs |
Implements symbol querying and output. |
cmd/soroban-cli/src/commands/token/mod.rs |
Registers and dispatches the command. |
cmd/soroban-cli/src/cli.rs |
Enables structured JSON errors. |
cmd/crates/soroban-test/tests/it/integration/token/symbol.rs |
Tests SAC symbols and deployment errors. |
cmd/crates/soroban-test/tests/it/integration/token/mod.rs |
Registers symbol integration tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
stellar token symbol, a read-only subcommand returning a token's SEP-41symbol()metadata. Resolves a token by--id(contract id, alias,native, orCODE:ISSUER) and prints the symbol as text or JSON.Why
Part of #2620 (typed SEP-41 + SAC client), following
name. Stacked on thetoken-namebranch; a thin wrapper overcontract invokereusingargs::invoke_by_positionandargs::not_deployed_error.Known limitations
N/A