Add stellar token name subcommand - #2710
Open
fnando wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds stellar token name for querying SEP-41 token metadata through the existing invocation pipeline.
Changes:
- Implements text and JSON name output.
- Registers the command and structured errors.
- Adds integration tests and help documentation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
FULL_HELP_DOCS.md |
Documents token name and XDR hint options. |
cmd/soroban-cli/src/commands/token/name.rs |
Implements the name query. |
cmd/soroban-cli/src/commands/token/mod.rs |
Registers the subcommand. |
cmd/soroban-cli/src/cli.rs |
Enables JSON error formatting. |
cmd/crates/soroban-test/tests/it/integration/token/name.rs |
Tests SAC metadata and errors. |
cmd/crates/soroban-test/tests/it/integration/token/mod.rs |
Registers name tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
FULL_HELP_DOCS.md:4540
- These newly documented flags are not implemented by
stellar xdr generate arbitrary: neitherhintnorhint_attemptsexists anywhere in the command source, so users following this help will get an unknown-argument error. Remove this unrelated generated-help fragment (or include the corresponding implementation in the PR).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
stellar token name, a read-only subcommand returning a token's SEP-41name()metadata. Resolves a token by--id(contract id, alias,native, orCODE:ISSUER) and prints the name as text or JSON.Why
Part of #2620 (typed SEP-41 + SAC client), following
transferandbalance. First of the per-command PRs; a thin wrapper overcontract invokereusingargs::invoke_by_positionandargs::not_deployed_error.Known limitations
N/A