Skip to content

Keep Claude account tabs in slot order - #5117

Draft
sfxsalem wants to merge 1 commit into
steipete:mainfrom
sfxsalem:claude-stable-account-tabs
Draft

sfxsalem wants to merge 1 commit into
steipete:mainfrom
sfxsalem:claude-stable-account-tabs

Conversation

@sfxsalem

@sfxsalem sfxsalem commented Nov 18, 2026 •

Copy link
Copy Markdown

Summary

In a segmented Claude account menu, switching accounts moves the active tab to the first position. With two accounts, the buttons swap places on every switch.

Keep the segmented buttons in numeric adapter slot order. The selection highlight and quota display still follow the active account. The stacked menu keeps its existing active-first ordering.

Verification

  • Added a regression test using slots 2 and 10, with each account active in turn.
  • A standalone Swift check exercised the production menu display model and confirmed that tab order stayed fixed across switches.
  • SwiftLint passed on the changed Swift files.
  • The macOS debug app built with Xcode 27.2 from the exact PR commit.

Native app evidence

These screenshots use synthetic accounts in an isolated macOS debug build of f1091f1.

@clawsweeper

clawsweeper Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-environment Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. P2 Normal priority bug or improvement with limited blast radius. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. and removed clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. clawsweeper:intake:needs-environment Preliminary submission classification; full source review pending. labels Nov 18, 2026
@clawsweeper

clawsweeper Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Codex review: ready, awaiting a maintainer decision.

What this changes

Keep segmented Claude account buttons in numeric slot order while preserving active-first stacked cards.

Example: Switch from Claude slot 2 to slot 10 in the segmented menu.

  • Before: Buttons move from [2, 10] to [10, 2].
  • After: Buttons remain [2, 10], while the highlight and quota card follow slot 10.

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) Native screenshots substantiate the focused repair and no actionable defect was found; product direction remains unresolved and Swift test execution is not established.
Proof confidence 🦞 diamond lobster (5/6) ✨ media proof bonus Sufficient (screenshot): The PR identifies an isolated macOS debug build of f1091f1 with synthetic accounts; inspected native-menu screenshots show fixed Personal/Work positions, changed selection and quotas, and preserved active-first stacked rendering, resolving the previous review's proof request.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Bug fix · Worth it: Needs a maintainer decision · Fix scope: Complete
User problem: Claude account buttons exchange positions after switching, making their locations unpredictable.
Reason: The improvement is concrete and narrowly scoped, but numeric positioning changes the feature owner's existing presentation and remains an owner choice.

Merge readiness

⏳ Ready, awaiting maintainer decision

Keep open: this PR provides a focused, working improvement with no introduced defects found; choosing fixed numeric tab positions still needs the feature owner's direction.

Priority: P2
Reviewed head: f1091f16822d7701fad84417d70ddd9861d81d26
Owner decision: Required. See Decision needed.

Decision needed

  • Question: Should segmented Claude account buttons keep numeric slot positions instead of following active-first projection order?
  • Recommendation: Keep numeric slot positions: Accept the proposed ordering so switching accounts preserves button locations.
  • Why: This changes presentation built by the feature owner, and neither this PR's discussion nor the original segmented-layout decision explicitly approves numeric positioning.

Before merge

None.

Findings

None.

Tests

  • Missing end-to-end proof: No base-fail/head-pass execution of the added regression test was supplied.
Agent review details

How this fits together

The Claude account projection supplies active-first snapshots to the menu display model, which supplies account buttons and selects the detail card.

flowchart TD
  A[Adapter account rows] --> B[Active first snapshots]
  B --> C[Claude menu display model]
  C --> D[Numeric slot ordered buttons]
  C --> E[Selected account detail card]
  B --> F[Stacked account cards]
Loading

Technical review

Best possible solution:

Use the existing display model to sort segmented buttons numerically while retaining source-owned selection and stacked ordering, if the feature owner accepts that presentation.

Do we have a high-confidence way to reproduce the issue?

Current-main source establishes the trigger: active-first projection feeds button order directly; the supplied native screenshots demonstrate the corrected behavior rather than a before-fix reproduction.

Is this the best way to solve the issue?

Sorting at the existing presentation owner is the smallest complete repair because shared active-first snapshots still serve stacked consumers.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 1f6da9bec444.

Provenance checked

Testing

Proof path: shipped entry point.

Security

None.

Evidence

What I checked:

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Labels

Label changes:

  • add proof: sufficient: Contributor real behavior proof is sufficient.
  • add proof: 📸 screenshot: Contributor real behavior proof includes screenshot evidence.
  • add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦞 diamond lobster and patch quality is 🐚 platinum hermit.
  • add status: ⏳ waiting on maintainer: Only explicit maintainer approvals or decisions remain; merge is still blocked.
  • remove rating: 🧂 unranked krab: Current PR rating is rating: 🦐 gold shrimp, so this older rating label is no longer current.
  • remove status: 📣 needs proof: Current PR status label is status: ⏳ waiting on maintainer.

Label justifications:

  • P2: Moving account buttons causes recurring interaction friction in the optional Claude multi-account menu without preventing switching.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦞 diamond lobster and patch quality is 🐚 platinum hermit.
  • status: ⏳ waiting on maintainer: Only explicit maintainer approvals or decisions remain; merge is still blocked.
  • proof: sufficient: Contributor real behavior proof is sufficient.
  • proof: 📸 screenshot: Contributor real behavior proof includes screenshot evidence.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

History

Review history (1 earlier review cycle)
  • reviewed 2026-11-18T13:44:28.189Z sha f1091f1 :: needs real behavior proof before merge. :: none

Reviewed November 18, 2026, 10:03 AM ET / 15:03 UTC (Revision 2).

@sfxsalem

Copy link
Copy Markdown
Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

🦞👀
Exact review queued.

Re-review progress:

@clawsweeper clawsweeper Bot added proof: sufficient Contributor real behavior proof is sufficient. proof: 📸 screenshot Contributor real behavior proof includes screenshot evidence. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on maintainer Only explicit maintainer approvals or decisions remain; merge is still blocked. and removed rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal priority bug or improvement with limited blast radius. proof: 📸 screenshot Contributor real behavior proof includes screenshot evidence. proof: sufficient Contributor real behavior proof is sufficient. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on maintainer Only explicit maintainer approvals or decisions remain; merge is still blocked.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant