Repository navigation
Conversation
Adds a bundled-only browser-local-storage host capability and an openai-platform plugin behind the opt-in web source.
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. What this changesThis PR adds an opt-in macOS OpenAI credit source through a bundled-plugin browser local-storage capability. Example: A ChatGPT Pro subscriber runs codexbar usage --provider openai --source web.
Review scores
ProductKind: Feature · Worth it: Needs a maintainer decision · Fix scope: Complete Merge readiness⛔ Blocked before merge - 1 item remains Keep open for an owner decision on the proposed browser local-storage capability; both earlier findings are addressed, and no new blocking defect was identified. Priority: P2 Decision needed
Before merge
FindingsNone. Tests
Agent review detailsHow this fits togetherThe provider fetch pipeline supplies a capability-gated browser-storage reader to the plugin engines; the OpenAI script exchanges a discovered access token for a Platform session and returns credit data through the shared app and CLI snapshot contract. flowchart TD
A[Explicit web source] --> B[OpenAI provider strategy]
B --> C[Plugin runtime and grant checks]
C --> D[Chromium local storage]
D --> E[OpenAI Platform plugin]
E --> F[OpenAI session and grants endpoints]
F --> G[Shared usage snapshot]
G --> H[CLI output]
Technical reviewBest possible solution: Land an owner-approved plugin credential contract that enables subscription-credit reads while preserving existing API credentials, project scoping, and Linux balance access. Do we have a high-confidence way to reproduce the issue? Current main exposes only auto/api OpenAI sources and lacks plugin browser local-storage discovery; the contributor supplies live CLI evidence for the added web source. Is this the best way to solve the issue? The implementation follows the requested plugin ownership boundary and reuses existing discovery and account-routing helpers, but its credential API remains an owner choice. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 1f6da9bec444. Provenance checked
TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (1 earlier review cycle)
Reviewed November 16, 2026, 10:46 AM ET / 15:46 UTC (Revision 2). |
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d9428fbf8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Design question for @steipete: would you accept a bundled-only
browser-local-storagehost capability, so the OpenAI subscription credit lookup can live in a JavaScript plugin? When you closed #5036 you wrote: "A plugin-compatible credential contract, or an approved host capability for this discovery, would change that decision." This draft is that capability plus the plugin, so the shape can be judged in code. If the answer is no, closing it is fine. Refs #5034 and #4844.ctx.browser.localStorage(origin, key)returns one{ id, label, value }per Chromium profile that holds the key, in the default browser order. It reusesBrowserLocalStorageAPI.live, the same discovery the DeepSeek importer uses, so no Keychain prompt and no WebViewlocalStorage: [{ origin, keys }]next to the capability, validated likecookieDomains. An undeclared origin or key, a user-installed plugin, and the off or manual cookie sources are denied before any read--source webgets a resolver, soautoandapitake the same path as main.openai.js,OPENAI_ALLOW_BALANCE_FALLBACKand the Linuxsess-route are untouched. Thewebmode is declared on macOS only, so CLI source checks on other platforms do not changeopenai-platform.tsplugin, built likegemini-web: readsoai-auth:onboard, skips JWTs whoseexphas passed,POST /v1/dashboard/onboarding/login, thenGET /v1/dashboard/billing/credit_grantswith thesess-key. It tries the next profile on a 401 and never refreshes, stores or rotates a tokenTwo identical live runs on ChatGPT Pro.
--source autoand--source apireturn the same HTTP 403 message as v0.84.0.Questions for you:
ctx.browser.cookieHeaderdoes, or an opaque handle likectx.browser.sessionsfor request-url cookies?