[6.x] Forms 2: Catch untranslated strings - #15315
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017bXhw33wJpycXEkAnSYqyw
the lang file is `form-fieldtypes.php`, so lookups against `statamic::form-fields` could never resolve. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017bXhw33wJpycXEkAnSYqyw
the status and datestamp columns had no labels, so headers were auto-humanized from the handles ("Datestamp") and disagreed with the json resource's "Date" label after the first xhr.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017bXhw33wJpycXEkAnSYqyw
example strings are translated by vue at render time, so the handful of fieldtypes wrapping them in `__()` were inconsistent with the rest. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017bXhw33wJpycXEkAnSYqyw
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017bXhw33wJpycXEkAnSYqyw
sentence-length strings belong in the lang files rather than being used as their own keys. the `image_choice` "allow multiple" instruction reuses the existing `select.config.multiple` string. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017bXhw33wJpycXEkAnSYqyw
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017bXhw33wJpycXEkAnSYqyw
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017bXhw33wJpycXEkAnSYqyw
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017bXhw33wJpycXEkAnSYqyw
concatenating the translated word with the label hardcoded english word order. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017bXhw33wJpycXEkAnSYqyw
matches the other new form fieldtypes, which translate their option labels. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017bXhw33wJpycXEkAnSYqyw
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017bXhw33wJpycXEkAnSYqyw
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017bXhw33wJpycXEkAnSYqyw
the blade partial got the reworked min-based padding in #15068, but the antlers partial was left on the old symmetric-padding approach with the separate half-star override. the `StarRating` ui component uses the newer math too. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017bXhw33wJpycXEkAnSYqyw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request catches any untranslated strings and wraps them in
__(). It also removes some TODOs in tests and aligns the Antlers/Blade star rating stubs.