Skip to content

fix: use supported Codex exec configuration - #229

Merged
robbycochran merged 1 commit into
mainfrom
fix/codex-exec-args
Sep 19, 2026
Merged

robbycochran merged 1 commit into
mainfrom
fix/codex-exec-args

Conversation

@robbycochran

Copy link
Copy Markdown
Collaborator

The pinned sandbox Codex CLI rejected the legacy --ask-for-approval and related CLI arguments before the reviewer started.

Move model, approval, and sandbox settings into the existing Codex config payload and keep the command line to the flags supported by the pinned image. Add a regression assertion for the obsolete flags.

@robbycochran
robbycochran merged commit 85a7887 into main Sep 19, 2026
11 of 12 checks passed
@robbycochran
robbycochran deleted the fix/codex-exec-args branch September 19, 2026 02:27
@stackrox-openshell-workflow stackrox-openshell-workflow Bot added the stackrox-ai-review Opt in to StackRox AI review label Sep 19, 2026
@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: stackrox/harness-openshell/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0d853c83-9afd-4ab0-85bd-56495a1e3892

📥 Commits

Reviewing files that changed from the base of the PR and between 09b3931 and 169b0b8.

📒 Files selected for processing (2)
  • tasks/github-pr-reviewer/workflow/codex-harness.yaml
  • test/pr_review_test.go
 _____________________________________________________________
< Return early? Yes. Return *something meaningful*? Also yes. >
 -------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stackrox-ai-review Opt in to StackRox AI review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant