Skip to content

feat: enable Codex PR reviews #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robbycochran merged 1 commit into from
Sep 19, 2026
+18 −2
Merged

feat: enable Codex PR reviews #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/ai-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,18 @@ permissions:

jobs:
review:
uses: stackrox/harness-openshell/.github/workflows/pr-review-reusable.yml@83fe9cb5690fadbd9078ac3d46cf83bc5cf8c5f7
uses: stackrox/harness-openshell/.github/workflows/pr-review-reusable.yml@709f4cc1744e82b8dbea887fa72af98ca539dc6c
with:
# `uses` pins the workflow adapter; harness-ref pins the checked-out
# Harness CLI/scripts. Keep both at the same release commit.
harness-ref: 83fe9cb5690fadbd9078ac3d46cf83bc5cf8c5f7
harness-ref: 709f4cc1744e82b8dbea887fa72af98ca539dc6c
review-label: stackrox-ai-review
allow-draft-reviews: false
review-agent: codex
codex-inference-provider: openai-inference

@stackrox-openshell-workflow stackrox-openshell-workflow Bot Sep 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model name gpt-5.6-luna appears to be a placeholder or a non-existent model. Please confirm and update it to a valid model name.

@stackrox-openshell-workflow stackrox-openshell-workflow Bot Sep 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model name gpt-5.6-luna appears to be a placeholder or a non-existent model. Please confirm and update it to a valid model name.

codex-model: gpt-5.6-luna
codex-workspace: codex-review
required-providers: '["github-review", "openai-inference"]'
openshell-github-app-client-id: ${{ vars.OPENSHELL_GITHUB_APP_CLIENT_ID }}
secrets:
VERTEX_AI_SERVICE_ACCOUNT_KEY: ${{ secrets.VERTEX_AI_SERVICE_ACCOUNT_KEY }}
Expand Down
11 changes: 11 additions & 0 deletions test/pr_review_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,17 @@ func TestGitHubAppTokenIsHostOnly(t *testing.T) {
if reviewJob.With["harness-ref"] != pinnedRef {
t.Fatalf("caller harness-ref does not match workflow pin %q", pinnedRef)
}
for name, want := range map[string]string{
"review-agent": "codex",
"codex-inference-provider": "openai-inference",
"codex-model": "gpt-5.6-luna",
"codex-workspace": "codex-review",
"required-providers": `["github-review", "openai-inference"]`,
} {
if reviewJob.With[name] != want {
t.Fatalf("caller input %s = %q, want %q", name, reviewJob.With[name], want)
}
}
if reviewJob.With["openshell-github-app-client-id"] != "${{ vars.OPENSHELL_GITHUB_APP_CLIENT_ID }}" {
t.Fatal("caller does not pass the GitHub App client ID variable")
}
Expand Down
Loading