refactor: execute task bundles through shared adapter #224
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,65 @@ | ||||||
| #!/usr/bin/env bash | ||||||
| # Execute one trusted task bundle through the harness workflow runner. | ||||||
| set -euo pipefail | ||||||
| umask 077 | ||||||
| cd "$(dirname "$0")/.." | ||||||
|
|
||||||
| workflow_file="${1:?usage: run-task.sh WORKFLOW OUTPUT_DIR RESULT_FILE}" | ||||||
| output_dir="${2:?usage: run-task.sh WORKFLOW OUTPUT_DIR RESULT_FILE}" | ||||||
| result_file="${3:?usage: run-task.sh WORKFLOW OUTPUT_DIR RESULT_FILE}" | ||||||
|
|
||||||
| [[ "$output_dir" == /* && "$result_file" == /* ]] || { | ||||||
| echo "task output and result paths must be absolute" >&2 | ||||||
| exit 1 | ||||||
| } | ||||||
| [[ "$workflow_file" != /* && "$workflow_file" != *..* ]] || { | ||||||
|
There was a problem hiding this comment. The validation for |
||||||
| echo "task workflow must be a trusted repository-relative path" >&2 | ||||||
| exit 1 | ||||||
| } | ||||||
|
|
||||||
| gateway="${OPENSHELL_GATEWAY:-openshell}" | ||||||
|
There was a problem hiding this comment. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Do not force a gateway when no environment target exists. When Proposed fix-gateway="${OPENSHELL_GATEWAY:-openshell}"
+gateway="${OPENSHELL_GATEWAY:-}"As per path instructions, preserve “flag > env > config target precedence.” 📝 Committable suggestion
Suggested change
🤖 Prompt for AI AgentsSource: Path instructions |
||||||
| workspace="${OPENSHELL_WORKSPACE:-}" | ||||||
| task_timeout="${TASK_TIMEOUT:-8m}" | ||||||
| kill_after="${TASK_KILL_AFTER:-35s}" | ||||||
| [[ "$task_timeout" =~ ^[0-9]+[smh]$ && "$kill_after" =~ ^[0-9]+[smh]$ ]] || { | ||||||
| echo "TASK_TIMEOUT and TASK_KILL_AFTER must be durations such as 8m or 35s" >&2 | ||||||
| exit 1 | ||||||
| } | ||||||
|
|
||||||
| check_required_providers() { | ||||||
| local required="${TASK_PROVIDERS:-[]}" | ||||||
| mkdir -p "$output_dir" | ||||||
| if ! jq -e 'type == "array" and all(.[]; type == "string" and test("^[A-Za-z0-9][A-Za-z0-9_.-]{0,62}$"))' <<< "$required" >/dev/null; then | ||||||
| echo "TASK_PROVIDERS must be a JSON array of provider names" >&2 | ||||||
| exit 1 | ||||||
| fi | ||||||
|
|
||||||
| local report="$output_dir/provider-check.json" | ||||||
| local provider | ||||||
| local provider_args=(--gateway "$gateway") | ||||||
| [[ -n "$workspace" ]] && provider_args+=(--workspace "$workspace") | ||||||
| if jq -e 'length == 0' <<< "$required" >/dev/null; then | ||||||
| jq -n --arg gateway "$gateway" --arg workspace "$workspace" \ | ||||||
| '{status:"skipped", gateway:$gateway, workspace:$workspace, providers:[]}' > "$report" | ||||||
| return | ||||||
| fi | ||||||
| while IFS= read -r provider; do | ||||||
| if ! timeout 60s openshell provider get "${provider_args[@]}" "$provider" >/dev/null 2>&1; then | ||||||
| jq -n --arg gateway "$gateway" --arg workspace "$workspace" --arg provider "$provider" \ | ||||||
| '{status:"failed", gateway:$gateway, workspace:$workspace, missing:[$provider]}' > "$report" | ||||||
| echo "required OpenShell provider is unavailable: $provider (gateway=$gateway workspace=${workspace:-default})" >&2 | ||||||
| exit 1 | ||||||
| fi | ||||||
| done < <(jq -r '.[]' <<< "$required") | ||||||
|
|
||||||
| jq -n --arg gateway "$gateway" --arg workspace "$workspace" --argjson providers "$required" \ | ||||||
| '{status:"available", gateway:$gateway, workspace:$workspace, providers:$providers}' > "$report" | ||||||
| } | ||||||
|
|
||||||
| check_required_providers | ||||||
|
|
||||||
| args=(workflow apply "$workflow_file" --output-dir "$output_dir" --result-file "$result_file") | ||||||
| [[ -n "$gateway" ]] && args+=(--gateway "$gateway") | ||||||
| [[ -n "$workspace" ]] && args+=(--workspace "$workspace") | ||||||
|
|
||||||
| exec timeout -s TERM -k "$kill_after" "$task_timeout" ./harness "${args[@]}" | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: stackrox/harness-openshell
Length of output: 13663
🏁 Script executed:
Repository: stackrox/harness-openshell
Length of output: 27475
Use the effective provider in OpenCode preflight.
required-providersis a generic provider list, and the workflow forwards it toscripts/run-task.shfor OpenCode as well as Codex. On the non-configured OpenCode path,scripts/pr-review.shcreatesgithub-review-$RANDOM-$$. Therefore,required-providers: '["github-review"]'makes preflight check the fixed name, fail, and stop beforeworkflow apply. Normalize the list at the handoff to preflight sogithub-reviewresolves to the actualREVIEW_GITHUB_PROVIDER; retain checks for other declared providers.🤖 Prompt for AI Agents