feat(valkey): add Key Value Store in the descriptions - #1754
Open
GokceGK wants to merge 2 commits into
Open
Conversation
relates to STACKITTPR-845
rubenhoenle
reviewed
Sep 8, 2026
rubenhoenle
reviewed
Sep 8, 2026
| if resp.Diagnostics.HasError() { | ||
| return | ||
| } | ||
| tflog.Info(ctx, "Valkey credential read") |
Member
There was a problem hiding this comment.
I wouldn't touch this. The resource is named valkey, so the log output shouldn't be something else.
Don't mix up improving documentation with changing log entries.
rubenhoenle
reviewed
Sep 8, 2026
| return | ||
| } | ||
| r.client = apiClient | ||
| tflog.Info(ctx, "Valkey credential client configured") |
rubenhoenle
reviewed
Sep 8, 2026
| "main": "Key Value Store(valkey) credential resource schema. Must have a `region` specified in the provider configuration.", | ||
| "id": "Terraform's internal resource identifier. It is structured as \"`project_id`,`region`,`instance_id`,`credential_id`\".", | ||
| "credential_id": "The credential's ID.", | ||
| "instance_id": "ID of the Valkey instance.", |
Member
There was a problem hiding this comment.
Same here, would leave it like it is.
As long as it's clear from the top-level description of the resource that valkey = Key Value Store I wouldn't touch anything else.
rubenhoenle
requested changes
Sep 8, 2026
rubenhoenle
left a comment
rubenhoenle
left a comment
Member
There was a problem hiding this comment.
I would suggest to only touch the description of the resources and nothing else.
Co-authored-by: Ruben Hönle <Ruben.Hoenle@digits.schwarz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITTPR-845
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)