feat(vpn): add network_config to VPN gateway resource - #1748
Conversation
Exposes networkConfig (predefinedNetworkPrefix, routingTableId) on stackit_vpn_gateway. See API specs for more information. Signed-off-by: Eduard Itrich <eduard.itrich@europapark.de>
|
Hello @itrich, thank you for your contribution! We already have a contribution that addresses this here #1720 and since we already have a internal tracking issue for that PR and it adds a few more features, we will proceed with that one. Therefore i will close your PR as a duplicate, sorry about that. If i missed anything and #1720 implements something different than you did, please feel free to ping me and reopen the PR. Additionally, thank you for reporting the API issue. I will get into contact with the respective service team to get this fixed ASAP. Again, feel free to reopen the PR or ping me if you have any concerns. Best regards, |
|
No problem @SerseusWasTaken and thank you for making me aware of the pending PR #1720. I'm happy to test this in our local fork (which we need to manage our VPN Gateway). |
Exposes networkConfig (predefinedNetworkPrefix, routingTableId) on stackit_vpn_gateway. See API specs for more information.
Description
network_config(predefined_network_prefix,routing_table_id) to thestackit_vpn_gatewayresource and data source, letting users attach a custompredefined network prefix and/or routing table.
predefined_network_prefixisRequiresReplace, matching the API'sconstraint that it can't be changed after gateway creation.
Blocker⚠️
NetworkConfig.PredefinedNetworkPrefixas[]string, but the API actuallyaccepts and returns a plain string. Reported upstream at
predefinedNetworkPrefix must be a string stackit-api-specifications#69. Until that's fixed and a new
SDK version is released, this PR routes the value through
AdditionalPropertieson the way out and reads the first slice element onthe way in. Follow-up cleanup commit planned once the spec/SDK fix ships.
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)