Skip to content

Fix typo in stackhpc_enable_ceph_glance_cow_optimisations variable (2025.1) - #2798

Merged
priteau merged 1 commit into
stackhpc/2025.1from
docs-fix-20261116
Nov 16, 2026
Merged

priteau merged 1 commit into
stackhpc/2025.1from
docs-fix-20261116

Conversation

@technowhizz

Copy link
Copy Markdown
Contributor

No description provided.

@technowhizz
technowhizz requested a review from jovial November 16, 2026 17:09
@technowhizz technowhizz self-assigned this Nov 16, 2026
@technowhizz
technowhizz requested a review from a team as a code owner November 16, 2026 17:09
@github-actions github-actions Bot added the waiting-review PR is waiting for a review label Nov 16, 2026
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Summary

Corrects the variable name to stackhpc_enable_ceph_glance_cow_optimisations in the Cephadm documentation and in a release note. Also removes a trailing blank line from the documentation.

The configuration guide and release note now use stackhpc_enable_ceph_glance_cow_optimisations for the Copy on write setting. The guide also removes a trailing blank line after the final deployment command.

Changes: Ceph COW documentation

Layer / File(s) Summary
Update the setting name
doc/source/configuration/cephadm.rst, releasenotes/notes/adjust-ceph-permissions-on-images-for-cinder-user-3154b995916ee27e.yaml
The guide and release note use stackhpc_enable_ceph_glance_cow_optimisations instead of stackhpc_enable_ceph_cow_optimisations. The guide also removes a trailing blank line after the final deployment command.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: Minimal · previous review 1cc0e

This updates documentation and a release note to use the correct setting name for Glance copy-on-write optimisations. It does not change runtime behaviour, so merge risk is minimal.

Pre-merge checks: Passed 2

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between d9325e0 and 1cc0e37.

Files selected for processing: 2

  • doc/source/configuration/cephadm.rst
  • releasenotes/notes/adjust-ceph-permissions-on-images-for-cinder-user-3154b995916ee27e.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 4

  • GitHub Check: CodeRabbit
  • GitHub Check: Ansible 2.18 lint with Python 3.12
  • GitHub Check: Ansible 2.17 lint with Python 3.10
  • GitHub Check: Tox docs with Python 3.12

@priteau priteau changed the title Fix typo in stackhpc_enable_ceph_glance_cow_optimisations variable Fix typo in stackhpc_enable_ceph_glance_cow_optimisations variable (2025.1) Nov 16, 2026
jovial
jovial previously approved these changes Nov 16, 2026
Comment thread doc/source/configuration/cephadm.rst Resolved
@github-actions github-actions Bot added waiting-author-response PR is waiting for the author to respond and removed waiting-review PR is waiting for a review labels Nov 16, 2026
@priteau
priteau disabled auto-merge November 16, 2026 20:31
@priteau
priteau merged commit b712764 into stackhpc/2025.1 Nov 16, 2026
37 checks passed
@priteau
priteau deleted the docs-fix-20261116 branch November 16, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-author-response PR is waiting for the author to respond

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants