Skip to content

Infra 702 - ceph sct ci multinode - #2778

Open
saadtariq38 wants to merge 3 commits into
stackhpc/2026.1from
INFRA-702-ceph-sct-ci-multinode
Open

saadtariq38 wants to merge 3 commits into
stackhpc/2026.1from
INFRA-702-ceph-sct-ci-multinode

Conversation

@saadtariq38

@saadtariq38 saadtariq38 commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Enabled Prometheus Ceph Mgr Exporter to be then used in the Cloud-Testing logic here: stackhpc/stackhpc-cloud-tests#22

Some fixes to firewall config since the networks in multinode compared to other deployments are different and so ports were not accessible.

Added config for the ceph tests to be run on top of existing ones during deployment

…etwork as well

The base rule opens 9283 on provision_oc, which storage hosts are not
attached to in this environment
and set OSD count to be used in the tests
@saadtariq38
saadtariq38 requested a review from a team as a code owner November 10, 2026 15:00
@github-actions github-actions Bot added the waiting-review PR is waiting for a review label Nov 10, 2026
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The CI multinode configuration enables the Ceph manager exporter, adds its firewall rule, derives the expected OSD count from inventory and renames a cephadm command variable. The cloud-test playbook passes Ceph settings to monitoring tests, runs Ceph tests on monitor hosts and collects their HTML results.

Changes: CI multinode Ceph testing

Layer / File(s) Summary
Configure CI multinode Ceph services
etc/kayobe/environments/ci-multinode/kolla.yml, etc/kayobe/environments/ci-multinode/inventory/group_vars/all/firewall.yml, etc/kayobe/environments/ci-multinode/stackhpc-ci.yml, etc/kayobe/environments/ci-multinode/cephadm.yml
The configuration enables the Ceph manager exporter and adds a conditional firewall rule for TCP port 9283. It sets the expected OSD count from the osds inventory group and renames cephadm_commands_post to cephadm_commands_post_extra.
Run Ceph tests and collect results
etc/kayobe/ansible/tools/stackhpc-cloud-tests.yml
Monitoring tests receive the Ceph manager exporter and RGW flags. When the Ceph test directory exists, the playbook runs tests on monitor hosts, sets the HTML result file mode to 666 and adds results to failed-tests when the test return code is non-zero.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Tests as stackhpc-cloud-tests.yml
  participant Pytest
  participant Results as Ceph HTML results
  participant Failures as failed-tests
  Tests->>Pytest: Run Ceph tests on mons
  Pytest-->>Tests: Return exit code and HTML results
  Tests->>Results: Set HTML result file mode to 666
  Tests->>Failures: Add HTML results when exit code is non-zero
Loading

Possibly related PRs

Merge Risk: Minimal · up to e9ce4

No actionable issue was established; the change is ready for normal CI validation, including confirmation that Ceph tests run on the intended monitor hosts.

Pre-merge checks: Passed 3

Check name Status Explanation
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 4cb5d3a and e9ce45a.

Files selected for processing: 5

  • etc/kayobe/ansible/tools/stackhpc-cloud-tests.yml
  • etc/kayobe/environments/ci-multinode/cephadm.yml
  • etc/kayobe/environments/ci-multinode/inventory/group_vars/all/firewall.yml
  • etc/kayobe/environments/ci-multinode/kolla.yml
  • etc/kayobe/environments/ci-multinode/stackhpc-ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@saadtariq38

saadtariq38 commented Nov 10, 2026 •

Copy link
Copy Markdown
Member Author

Update: Dependancy has been merged so this comment can be ignored

Dont merge until https://github.com/stackhpc/stackhpc-kayobe-config/pull/2337/changes has been merged

@saadtariq38
saadtariq38 requested a review from MoteHue November 11, 2026 09:13

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-review PR is waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant