Skip to content

chore: Bump the Rust toolchain to 1.97.1 - #142

Open
lfrancke wants to merge 3 commits into
mainfrom
chore/rust-1.97.1
Open

chore: Bump the Rust toolchain to 1.97.1#142
lfrancke wants to merge 3 commits into
mainfrom
chore/rust-1.97.1

Conversation

@lfrancke

Copy link
Copy Markdown
Member

No description provided.

@lfrancke lfrancke changed the title chore: bump the Rust toolchain to 1.97.1 chore: Bump the Rust toolchain to 1.97.1 Aug 25, 2026
@lfrancke lfrancke self-assigned this Aug 25, 2026
@lfrancke lfrancke moved this to Development: Waiting for Review in Stackable Engineering Aug 25, 2026

@Techassi Techassi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, but the commits don't seem to be signed.

@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 27, 2026
@lfrancke

Copy link
Copy Markdown
Member Author

That is not an AI artefact. I have no idea why that sometimes happens. This started a few weeks ago. Something with my config must be borked and I alread ylooked but everything looks as always.

I can probably rewrite them and force push if you prefer?

@Techassi

Techassi commented Aug 28, 2026

Copy link
Copy Markdown
Member

Something with my config must be borked

Mhm weird indeed. My (global) config has this, which has been working fine:

[user]
  email = <YOUR_EMAIL>
  name = <YOUR NAME>
  signingkey = <KEY ID>

[commit]
  gpgsign = true

I can probably rewrite them and force push if you prefer?

You actually have to do this, otherwise we would need to disable signed commits (which I argue we don't want, even if temporary). So yes re-signing and re-pushing them is the way to go. Basically do this:

git rebase --exec 'git commit --amend --no-edit --no-verify --gpg-sign' origin/main
git push --force-with-lease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

2 participants