test: warn in both directions when only one service origin is set - #5451
Merged
Conversation
Setting only RESPEC_SERVICES_BASE leaves bibliography's first attempt on api.specref.org, which is the same false green as the case already covered, so the warning now fires for either variable and names the one that is missing. The docs claimed both directions while the code covered one. Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot's two findings on #5450. The warning covered only SPECREF_BASE, but setting only RESPEC_SERVICES_BASE leaves bibliography's first attempt on api.specref.org, which is the same false green, so it now fires for either variable and names the one that is missing. The doc line claimed both directions while the code covered one.
Written with Claude.