ENG-31: Solid-OIDC Client Id Document support - #17
Conversation
# Conflicts: # index.html # src/DPoPTokenProvider.ts # src/mod.ts # src/reactive-fetch-worker.ts
ea1bcdf to
bc18ae9
Compare
bc18ae9 to
9f1e4a3
Compare
langsamu
changed the title
| const cachingASProvider = new CachingAuthorizationServerProvider(asProvider) | ||
| const callbackUri = new URL("/callback.html", location.href).toString() | ||
| const clientProvider = new DynamicRegistrationClientProvider | ||
| // const clientProvider = new ClientIdClientProvider(new URL("./id.jsonld", location.href)) |
There was a problem hiding this comment.
Why do we have things commented out in a PR?
There was a problem hiding this comment.
This index.html file is what currently goes for test/demo harness.
These commented lines facilitate experimentation with the new feature.
This is far from done, to be replaced down the line with unit tests, documentation comments and example code.
Would you like me to remove here or are you OK for this to evolve slowly?
| } | ||
|
|
||
| async getClient(_: oauth.AuthorizationServer, __: string, signal: AbortSignal): Promise<oauth.Client> { | ||
| const response = await fetch(this.clientIdDocUri, {signal}) |
There was a problem hiding this comment.
This looks like it will get overriden when we are monkey patching and so suffer from the issues that #21 tries to fix.
There was a problem hiding this comment.
Yes, relying on the global fetch makes this prone to the same problem.
I'd rather not mitigate that here but treat it holistically across the codebase.
Especially considering #19 and the potential to eliminate monkey patching altogether.
I imagine the best approach would be (as hinted in #21) would be for our API to take a fetch and perhaps for the manager to pass its original fetch to these methods. Even regardless of not monkey patching.
2 participants
Implements the titular feature.
To run in demo mode, requires
localhost(e.g.so it can reference a client Id doc on
localhost.