Skip to content

interface: Allow a missing validation account in the offchain helper - #195

Merged
joncinque merged 1 commit into
solana-program:mainfrom
Iamsohungrynow:fix/offchain-optional-validation-account
Nov 20, 2026
Merged

joncinque merged 1 commit into
solana-program:mainfrom
Iamsohungrynow:fix/offchain-optional-validation-account

Conversation

@Iamsohungrynow

Copy link
Copy Markdown
Contributor

the onchain add_extra_accounts_for_execute_cpi treats the validation account as optional, but the offchain add_extra_account_metas_for_execute returned InvalidAccountData when it was missing. now it adds just the program id in that case, same as onchain

@joncinque joncinque left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution -- can you rebase your branch onto main to pick up the audit fix?

@Iamsohungrynow
Iamsohungrynow force-pushed the fix/offchain-optional-validation-account branch from 82d469c to 9b508b5 Compare November 20, 2026 10:33
@Iamsohungrynow

Copy link
Copy Markdown
Contributor Author

rebased! thank you~

@joncinque joncinque left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joncinque
joncinque merged commit 109d508 into solana-program:main Nov 20, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants