Skip to content

Handle Windows file paths and ensure full system path is not stored - #1008

Merged
kzscisoft merged 14 commits into
devfrom
kzscisoft/windows-artifacts
Sep 21, 2026
Merged

kzscisoft merged 14 commits into
devfrom
kzscisoft/windows-artifacts

Conversation

@kzscisoft

Copy link
Copy Markdown
Collaborator

Fix Windows File Artifact Save

Issue: N/A

Python Version(s) Tested: 3.14

Operating System(s): Ubuntu 26.04

📝 Summary

  • Windows-style paths not supported on save_file.
  • Security issue relating to save of full path as name.

🔍 Diagnosis

During testing on Windows it was discovered that save_file was failing due to the artifact name commencing with C:\ which is not supported. It was also noted that when the user selects to preserve the file path the API stores the full path on the system which flags security related issues.

🔄 Changes

  • Windows paths are converted to POSIX before being assigned as artifact name.
  • Path relative either to project .git directory, or to the current working directory is used.

✔️ Checklist

  • Unit and integration tests passing.
  • Pre-commit hooks passing.
  • Quality checks passing.

@kzscisoft kzscisoft self-assigned this Sep 18, 2026
@kzscisoft kzscisoft added bug Something isn't working python Pull requests that update python code Windows Window specific issues labels Sep 18, 2026
@kzscisoft
kzscisoft force-pushed the kzscisoft/windows-artifacts branch from 7b16de1 to 641a03e Compare September 18, 2026 09:09
@kzscisoft
kzscisoft force-pushed the kzscisoft/windows-artifacts branch from 9bab5b6 to c637616 Compare September 18, 2026 09:40
@kzscisoft
kzscisoft force-pushed the kzscisoft/windows-artifacts branch from c637616 to d57593c Compare September 18, 2026 09:44
@kzscisoft
kzscisoft force-pushed the kzscisoft/windows-artifacts branch from e2b6622 to e04282d Compare September 18, 2026 11:10
Comment thread tests/functional/test_run_class.py Fixed
@kzscisoft
kzscisoft merged commit 24fa3dd into dev Sep 21, 2026
22 checks passed
@kzscisoft
kzscisoft deleted the kzscisoft/windows-artifacts branch September 21, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working python Pull requests that update python code Windows Window specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant