[armory] Use item stats directly from the API for correct catalyzed item stats - #11850
Open
seriallos wants to merge 1 commit into
Open
[armory] Use item stats directly from the API for correct catalyzed item stats#11850seriallos wants to merge 1 commit into
seriallos wants to merge 1 commit into
Conversation
…tem stats There's no indication from the API that a tier item was catalyzed from something else except for the actual stats on the item. No bonus ID or additional property in the JSON shows up. So the simplest way to get things working is just to accept all the stats from the Armory and push them using the stats= attribute on an item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no indication from the API that a tier item was catalyzed from something else except for the actual stats on the item. No bonus ID or additional property in the JSON shows up. So the simplest way to get things working is just to accept all the stats from the Armory and push them using the stats= attribute on an item.
Example API JSON for the stats of a catalyzed feral druid chest below. I didn't try to match the AgiInt hybrid stat, just drops any stat not appropriate for the spec and keeps the main stat.