Repository navigation
chore(db): drop organization.whitelabel_settings and rate_limit_bucket - #10303
Draft
waleedlatif1 wants to merge 1 commit into
Draft
waleedlatif1 wants to merge 1 commit into
waleedlatif1 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The contract phase for two objects v0.9.65 no longer declares or uses:
organization.whitelabel_settings: un-declared in 0468 (chore(cleanup): remove dead chart options, the playground and legacy chat routes; contract retired DB objects #10269). Drizzle doesn't generate this drop, so it's hand-written.rate_limit_bucket: Redis is required (chore(redis): require Redis and remove the no-Redis fallbacks #10272), so the Postgres token bucket and provider-capacity store are gone. This removes the table declaration and bothcontract-pendingmarkers.Migration 0470 follows the 0409/0468 pattern:
COMMIT,lock_timeout = '100ms'for the drops,IF EXISTS, then back to5s.rate_limit_buckethas no foreign keys in either direction and no secondary indexes (0119, 0326, 0330), so there's noCASCADE.The
CREATE TABLE rate_limit_bucketstubs in the two migration-replay fixtures stay, because replaying 0326 alters that table.Type of Change
Testing
drizzle-kit generateis a no-op.check:migrations origin/stagingpasses. Removing either-- migration-safeline makes it fail, so the annotations are load-bearing.check:pending-drop-tablesandcheck:schema-mockpass.apps/simtype-check is clean.Checklist