Repository navigation
chore(cleanup): simplify what the Redis, config and removal changes left behind - #10286
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge. SummaryRemoves leftover branches and unused APIs after Redis became required and deployment settings were consolidated.
No actionable issues found. Review was based on source inspection; tests were not run. Reviews (1) · Last reviewed commit: "chore(cleanup): simplify what the Redis,..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 112 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup of what the Redis-required (#10272), deployment-config (#10271) and removal (#10246, #10269) changes left behind. No product behavior changes.
Redis leftovers
TEST_REDIS_URLskip gates, hoists and env restores. The integration setup already requires it and setsREDIS_URL.readTestRedisUrl()returnsstringand always throws when unset.disposedflag in the pub/sub channel, and thegetMarkerClientpass-through.provider-missing-fieldprompt condition; its only user was the removed cache setup.redisAvailabledescription and regenerate the OpenAPI JSON.Config
severityfield.registrationMode.model-list.ts.Removed-feature leftovers
lib/brandingaway:SIM_SUPPORT_EMAILmoves to@sim/utils/site, and the email wordmark size is inlined.brandTertiarycolor and a dead footermessageIdprop.Docs and Helm
validateRedis.envDefaultsentries..env.example(thesim-setupcommand and the enterprise list), the Ollama overlay comment, and the contributor quick start (POSTGRES_PASSWORD,REDIS_URL).Type of Change
Testing
bunx turbo run type-checkacross all workspaces.check:test-types,check:test-patterns,check:unused-exports,check:api-validation:strict,check:client-boundary,check:boundaries,check:utils,check:comment-hygiene,check:file-names,check:deployment-config,check:docs-manifest,check:openapi,check-explicit-any. Baselines only shrink.--verify-compatibility; compose overlay config.Checklist
test-auditauthoring gate)