Skip to content

chore(cleanup): simplify what the Redis, config and removal changes left behind - #10286

Merged
waleedlatif1 merged 2 commits into
stagingfrom
chore/post-merge-cleanup
Nov 21, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
chore/post-merge-cleanup

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Cleanup of what the Redis-required (#10272), deployment-config (#10271) and removal (#10246, #10269) changes left behind. No product behavior changes.

Redis leftovers

  • apps/sim integration suites: drop the dead TEST_REDIS_URL skip gates, hoists and env restores. The integration setup already requires it and sets REDIS_URL.
  • readTestRedisUrl() returns string and always throws when unset.
  • Remove dead null-client guards, a duplicated disposed flag in the pub/sub channel, and the getMarkerClient pass-through.
  • Flatten the one-field desktop executor prop to a boolean.
  • Drop sim-setup's provider-missing-field prompt condition; its only user was the removed cache setup.
  • Fix comments and docs that still described a Postgres or in-memory fallback.
  • Update the public redisAvailable description and regenerate the OpenAPI JSON.

Config

  • The deployment projection reader parses directly, with no memo. Its features reader always returns a state.
  • Inline single-use sandbox availability.
  • Registration warnings drop the redundant severity field.
  • The env-flags mock derives the registration booleans from registrationMode.
  • The vLLM and LiteLLM model routes share one helper. The blacklist stays in the routes, to keep the executor graph out of model-list.ts.

Removed-feature leftovers

  • Fold lib/branding away: SIM_SUPPORT_EMAIL moves to @sim/utils/site, and the email wordmark size is inlined.
  • Remove the whitelabel-era email brandTertiary color and a dead footer messageId prop.
  • Remove the auth-UI logo and legal-href slots, which always took the same values.
  • Remove emcn popover's unused item-registration API.
  • Merge the tag-dropdown folder wrapper into the component it wrapped.
  • Give the abort rewrite a dated removal note.

Docs and Helm

  • One "Configuration changes by release" note in the self-hosting upgrade guide.
  • Helm README: the Redis note is labeled 1.15.0, and notes are added for 1.12, 1.13 and 1.14.
  • Consistent schema stub descriptions, and the Redis source lists match validateRedis.
  • Remove dead empty envDefaults entries.
  • Fix the stale "optional Redis" wording, .env.example (the sim-setup command and the enterprise list), the Ollama overlay comment, and the contributor quick start (POSTGRES_PASSWORD, REDIS_URL).
  • Chart 1.15.2; docs compatibility baseline recomputed.

Type of Change

  • Chore / cleanup

Testing

  • bunx turbo run type-check across all workspaces.
  • check:test-types, check:test-patterns, check:unused-exports, check:api-validation:strict, check:client-boundary, check:boundaries, check:utils, check:comment-hygiene, check:file-names, check:deployment-config, check:docs-manifest, check:openapi, check-explicit-any. Baselines only shrink.
  • Targeted vitest across config, providers, auth, emails, pubsub, logs and desktop; emcn, sim-setup and deployment-config suites.
  • 4 rewritten integration suites run against disposable Postgres and Redis (44 tests).
  • Helm lint, unittest (141), and template over every example and CI values file; docs --verify-compatibility; compose overlay config.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 21, 2026 10:03am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Removes leftover branches and unused APIs after Redis became required and deployment settings were consolidated.

  • Redis integration tests always use the shared required-URL setup.
  • Configuration readers and mocks give callers a complete feature state without extra wrapper logic.
  • The vLLM and LiteLLM model routes use one shared model-listing path.
  • Auth screens, email footers, popovers, and sidebar props drop unused customization layers.
  • The setup wizard no longer asks about a missing provider field for removed cache setup.
  • Self-hosting and Helm guidance reflects required Redis and newer removal notes.
  • Small comments, mocks, and generated baselines catch up with earlier cleanup.

No actionable issues found. Review was based on source inspection; tests were not run.

Reviews (1) · Last reviewed commit: "chore(cleanup): simplify what the Redis,..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 112 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/.env.example Resolved
@waleedlatif1
waleedlatif1 merged commit 825a419 into staging Nov 21, 2026
98 checks passed

This branch was successfully deployed

1 active deployment
Preview — badf3867 Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant