Repository navigation
improvement(ci): drop the e2e build's persistent compiler cache - #10281
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] This PR appears safe to merge. SummaryRemoves the persistent compiler cache from E2E builds while keeping complete Turbo build outputs reusable.
No actionable issues found. Reviews (2) · Last reviewed commit: "chore(ci): drop the dead build-cache pru..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
waleedlatif1
force-pushed
the
ci/drop-build-compiler-cache-v2
branch
from
November 21, 2026 09:35
0b4adca to
8f3ee6f
Compare
…iler cache removal
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build (e2e): the plan, mount and two prune steps, and the now-deadNEXT_BUILD_PERSISTENT_CACHEflag (env.ts,turbo.json).next.config.tssetsturbopackFileSystemCacheForBuild: falseexplicitly, because Next enables it by default (this PR's first run, without the explicitfalse, still spent 33.8s writing the cache to a discarded disk)prune-turbopack-cache.mtsdrops its now-unused--buildmode and the tests that only covered it; it caps the dev cache as before..github/CI.mddescribes the removalBuild applicationran 239s at p50 against 186s in the earlier baseline. That build gates every e2e job, so the write and the slower compiles sit directly on the PR critical path (preliminary post-merge PR wall p50 537s)On this PR's own runs (each a real compile, since the PR changes
next.config.ts):Type of Change
Testing
next.config.ts, so its ownbuild (e2e)compiles cold; its time is the first after-sample. More come from the PR runs that followChecklist
test-auditauthoring gate)