Skip to content

improvement(ci): drop the e2e build's persistent compiler cache - #10281

Merged
waleedlatif1 merged 3 commits into
stagingfrom
ci/drop-build-compiler-cache-v2
Nov 21, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
ci/drop-build-compiler-cache-v2

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Removes the Turbopack persistent compiler cache from build (e2e): the plan, mount and two prune steps, and the now-dead NEXT_BUILD_PERSISTENT_CACHE flag (env.ts, turbo.json). next.config.ts sets turbopackFileSystemCacheForBuild: false explicitly, because Next enables it by default (this PR's first run, without the explicit false, still spent 33.8s writing the cache to a discarded disk)
  • prune-turbopack-cache.mts drops its now-unused --build mode and the tests that only covered it; it caps the dev cache as before. .github/CI.md describes the removal
  • The earlier A/B (improvement(ci): drop the e2e build's persistent compiler cache #10248/chore(ci): experiment, compiler cache on (do not merge) #10249) kept the cache on its best case: a warm cache compiling code identical to what it holds took 113s. Real PRs never compile that. These are the last eight real PR compiles on staging-based branches, each restoring the shared cache:
compile cache write
cache on (real PRs, 2026-11-21) 2.9–4.6 min 15–37s
cache off (forced, #10248) 2.9–3.1 min none

On this PR's own runs (each a real compile, since the PR changes next.config.ts):

run compile cache write Build application
cache on (first run) 2.9 min 33.8s 3m40s
cache off 2.5 min none 3m01s
cache off, rebased 2.5 min none 3m00s

Type of Change

  • Improvement

Testing

  • actionlint, biome
  • This PR changes next.config.ts, so its own build (e2e) compiles cold; its time is the first after-sample. More come from the PR runs that follow

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 21, 2026 9:46am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

Removes the persistent compiler cache from E2E builds while keeping complete Turbo build outputs reusable.

  • E2E builds compile without Next’s persistent compiler cache.

No actionable issues found.

Reviews (2) · Last reviewed commit: "chore(ci): drop the dead build-cache pru..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread .github/workflows/checks.yml Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 7a902fc into staging Nov 21, 2026
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant