Skip to content

fix(e2e): distinguish WebKit viewport diagnostics from editor errors - #10270

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/markdown-webkit-viewport-diagnostic
Nov 21, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/markdown-webkit-viewport-diagnostic

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Keep the cached-navigation browser check strict for editor failures while recognizing the bundled CI WebKit's exact ignored viewport option diagnostic.
  • Preserve all navigation, formatting, suggestion, Find, saved-content, and uncaught-error assertions.

Type of Change

  • Bug fix

Testing

  • The prior CI run passed all interaction and persistence assertions, then failed only on this exact browser compatibility diagnostic.
  • Test-audit reviewed the exception: only WebKit and exact full-message equality qualify; all other console errors remain failures.
  • Markdown viewer E2E, lint, and the aggregate required-check gate passed in CI.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 21, 2026 1:59am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; the exception is limited to the intended WebKit diagnostic.

Summary

Updates the cached-navigation E2E check to ignore one exact WebKit viewport diagnostic.

  • The cached-navigation check ignores one WebKit viewport warning.

Reviews (2) · Last reviewed commit: "fix(e2e): distinguish WebKit viewport di..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 marked this pull request as ready for review November 21, 2026 02:06

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 3153f6e into staging Nov 21, 2026
50 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/markdown-webkit-viewport-diagnostic branch November 21, 2026 03:13

This branch was previously deployed

1 inactive deployment
Preview — a5c50a56 Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant