Repository navigation
test(knowledge): report the window walk's index condition, filter and loops when it reads past its bound - #10267
Merged
Merged
Conversation
… loops when it reads past its bound
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Low impact] This diagnostics-only change appears safe to merge. SummaryAdds query-plan details to failures in the reconciliation-window integration tests.
The existing intermittent bound failure remains outside this PR: Reviews (1) · Last reviewed commit: "test(knowledge): report the window walk'..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
listing-continuation.integration.ts› "scans a dense window once and never reads every tombstone of the connector" fails intermittently in CI. The reconciliation window walk plans its per-step probe ondocument_pkeyand reads ~14.5k rows against its 5,000-row bound: about three rows per step, two removed by the filterdocumentscan in the failure message now also carries itsIndex Cond,Filter, rows per loop, rows removed per loop and loop count. The bound and every assertion are unchangedType of Change
Testing
Checklist
test-auditauthoring gate)