Skip to content

test(knowledge): report the window walk's index condition, filter and loops when it reads past its bound - #10267

Merged
waleedlatif1 merged 1 commit into
stagingfrom
test/listing-plan-diagnostics
Nov 21, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
test/listing-plan-diagnostics

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • listing-continuation.integration.ts › "scans a dense window once and never reads every tombstone of the connector" fails intermittently in CI. The reconciliation window walk plans its per-step probe on document_pkey and reads ~14.5k rows against its 5,000-row bound: about three rows per step, two removed by the filter
  • It has failed on a staging validation and three PR branches, but not in five isolated local runs, so it likely depends on rows earlier files in the same shard leave behind. The assertion only reported each scan's name and row total, which can't say which rows the walk passed over
  • Each document scan in the failure message now also carries its Index Cond, Filter, rows per loop, rows removed per loop and loop count. The bound and every assertion are unchanged

Type of Change

  • Improvement (test diagnostics)

Testing

  • The integration shards on this PR run the file; the new fields only appear in a failure message

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 21, 2026 1:16am UTC

Request Review

@waleedlatif1
waleedlatif1 merged commit 4e7840d into staging Nov 21, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the test/listing-plan-diagnostics branch November 21, 2026 01:16
@greptile-apps

greptile-apps Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This diagnostics-only change appears safe to merge.

Summary

Adds query-plan details to failures in the reconciliation-window integration tests.

  • Bound-check failures show how each document scan read its rows.

The existing intermittent bound failure remains outside this PR: waleedlatif1 explicitly describes this as a diagnostics-only change.

Reviews (1) · Last reviewed commit: "test(knowledge): report the window walk'..." · Reviewed by Greptile

This branch was previously deployed

1 inactive deployment
Preview — 5d7fe080 Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant