Skip to content

fix(files): avoid Markdown editor crashes on cached navigation - #10266

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/markdown-cached-navigation
Nov 21, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/markdown-cached-navigation

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Prevent "Failed to load files" on cached Markdown routes by guarding menu, suggestion, toolbar, and Find hooks until TipTap replaces the destroyed editor.
  • Verify restored formatting shortcuts, slash commands, Find counting/stepping, hover controls, and persisted edits after repeated cached folder/file navigation.
  • Wait for DOM readiness on cold navigation, read saved content through stable file references, and isolate polling-verifier quotas from browser visitors.

Type of Change

  • Bug fix

Testing

  • Regression reproduced on the unfixed code and verified with the fix.
  • The control regression also fails when the toolbar keyboard binding is removed in a browser negative control.
  • 732 focused editor tests passed.
  • Restored-control coverage passed in Chromium and WebKit, including saved formatting and Find stepping.
  • Repository tests, the complete Markdown viewer browser matrix, and the production build run in CI on the final head and must pass before merge.
  • Lint, type checking, block registry, all 68 audits, and all 15 artifact generators passed.
  • Cleanup reviewed React lifecycle, state, memoization, callbacks, query/URL state, design, comments, and the E2E authoring gate.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 21, 2026 1:44am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge, with no new actionable issues found.

Summary

Adds isDestroyed checks so Markdown menus and Find skip disposed editors during cached navigation.

  • Markdown controls stay available when cached file navigation replaces the editor.

Reviews (3) · Last reviewed commit: "fix(files): avoid stale editor views on ..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 force-pushed the fix/markdown-cached-navigation branch from 717f18f to 007ef06 Compare November 21, 2026 01:44
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit a0aca94 into staging Nov 21, 2026
115 of 117 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/markdown-cached-navigation branch November 21, 2026 01:50
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

This branch was previously deployed

1 inactive deployment
Preview — 007ef069 Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant