Repository navigation
fix(e2e): restore the keyboard-only markdown selection and wait for it to apply - #10265
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Low impact] The PR appears safe to merge. SummaryRestores browser-driven text selection in the Markdown viewer test.
Reviews (1) · Last reviewed commit: "fix(e2e): restore the keyboard-only mark..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getSelection().collapseinside "bold") to the original keyboard-only click → ArrowLeft → Shift+ArrowRight. In WebKit the programmatic caret did not hold: "Keyboard selection did not select text" failed on two of four runs after improvement(ci): install e2e browser system packages from a per-image cache #10258 merged, against two of roughly sixty before itType of Change
Testing
Checklist
test-auditauthoring gate)