Repository navigation
chore(mothership): take the remaining contracts from the worker and drop the Go contract generators - #10264
Open
waleedlatif1 wants to merge 4 commits into
Open
chore(mothership): take the remaining contracts from the worker and drop the Go contract generators#10264waleedlatif1 wants to merge 4 commits into
waleedlatif1 wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Contributor
[Medium impact] This PR appears safe to merge. SummaryMoves eight Mothership contracts from Sim’s Go-schema generators to worker-owned TypeScript copies.
No actionable issues were found. This review used source inspection; no tests or generators were run.
|
…rop the Go contract generators The Go copilot is being removed from the mothership repo. The eight contracts Sim generated from its JSON (stream, billing protocol, vfs snapshot, trace and metric names) are now worker-owned TypeScript copied in by the worker's contracts:sync, so the eight json2ts sync scripts and the mship:generate umbrella go. The base tool catalog moves to the worker's packages/contracts, and mship-tools:generate reads it there.
waleedlatif1
force-pushed
the
chore/mship-contracts-from-worker
branch
from
November 21, 2026 00:25
36ddb85 to
4ac688b
Compare
…ip note's catalog path a placeholder
…del-router contract The worker now serves POST /api/model-router again (mothership D116); only the Go service did, so every sim-auto block has fallen back to its default model since the cutover. The resolver takes its request and response types from the synced contract instead of a hand-kept copy.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Go copilot is being removed from the mothership repo, so its JSON contracts are no longer generated
The eight contracts Sim generated from that JSON (
mothership-stream-v1,billing-protocol-v1,vfs-snapshot-v1, the fourtrace-*files,metrics-v1) are now worker-owned TypeScript copied in by the worker'scontracts:sync, like every other file inlib/mothership/generated/Content is unchanged apart from headers and formatting. Two exceptions: the
task_armedtargettype goes from{}toRecord<string, unknown>(the schema always saidtype: object), and two doc comments now say "worker" instead of "Go"Removes the eight json2ts sync scripts, their
*:generate/*:checkpackage scripts, and themship:generateumbrellaDrops the now-unused
json-schema-to-typescriptdev dependencymship-tools:generatenow reads the base tool catalog from../copilot/worker/packages/contracts/tool-catalog-v1.json; the regenerated output only changes its header lineThe worker serves
POST /api/model-routeragain (mothership D116). Only the Go service did, so sim-auto has fallen back to its default model since the cutover.lib/model-router/resolve.tsnow types its request and response from the syncedgenerated/model-router.tsinstead of a hand-kept copyCompanion: simstudioai/mothership#995
Type of Change
Testing
tsc --noEmitinapps/simcleanlib/model-routertests passcheck:source-conventionsand biome passmship-tools:checkpasses against the moved catalogcheck:contract-syncpasses against this branchChecklist