Skip to content

fix(markdown): preserve formatting and literal text on paste - #10261

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/markdown-paste-parity
Nov 21, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/markdown-paste-parity

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Use the file parser's Markdown grammar and bounded blocks to detect formatting on paste, including underlined headings, tilde fences, indented code, and reference links.
  • Honor explicit Markdown clipboard content, keep ordinary angle-bracket prose literal, and preserve rich HTML, plain-text paste, code, and size admission.
  • Add browser coverage for paste persistence, code-editor clipboard metadata, and external file updates followed by local edits.

Type of Change

  • Bug fix

Testing

  • Full repository suite: 50,522 tests passed. Command: VITEST_MAX_WORKERS=8 bun run test --concurrency=1.
  • 732 focused editor tests; regression checks fail with each fix removed.
  • 61 PostgreSQL integration checks covering file content, collaboration access, and agent file writes.
  • 66 Chromium/WebKit browser checks across 320, 390, 768, and 1440 pixels in light/dark modes, including paste/save/reopen and external-update persistence. JSON reports and screenshots captured locally.
  • Lint, type checking, block registry, and all 68 repository audits.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 20, 2026 11:57pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The reviewed changes appear safe to merge.

Summary

Aligns clipboard Markdown detection with the file parser while keeping rich HTML and literal paste paths.

  • Pasted Markdown now follows the same rules as opened files.
  • Paste limits now count the clipboard text the editor will use.

No actionable new issues were found in the changes since the previous review.

Reviews (3) · Last reviewed commit: "fix(markdown): keep angle-bracket prose ..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@waleedlatif1 waleedlatif1 changed the title fix(markdown): align clipboard parsing with file rendering fix(markdown): preserve formatting and literal text on paste Nov 21, 2026
@cubic-dev-ai

cubic-dev-ai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 9964728 into staging Nov 21, 2026
78 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/markdown-paste-parity branch November 21, 2026 00:05

This branch was previously deployed

1 inactive deployment
Preview — 28296f00 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant