Repository navigation
fix(workspace-source): retry blobs a sweep kept even when the next sweep starts in the same millisecond - #10256
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no new blocking issues were found. SummaryFailed blob deletes now stay eligible for a later sweep, even when both sweeps start in the same millisecond.
No new actionable issues were found. waleedlatif1 accepted keeping the exclusion without a dedicated full-batch test because that test would require hundreds of undeletable objects or a test-only batch-size setting. Greptile conceded the earlier comment. Reviews (2) · Last reviewed commit: "fix(workspace-source): retry blobs a swe..." · Reviewed by Greptile |
5 of 6 tasks
…eep starts in the same millisecond
waleedlatif1
force-pushed
the
fix/staging-sweep-same-ms
branch
from
November 20, 2026 20:46
32c56d0 to
5e8db05
Compare
Collaborator
Author
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sweepExpiredStagedBlobsmoved a row whose object it couldn't delete toexpiresAt = sweepStart, and the next sweep only takes rows withexpiresAt < its own start. When the next sweep started in the same millisecond, the kept row was skipped. This failedstaging.integration.ts("a later sweep removes both") on an unrelated PRsweepStart - 1ms, so any later sweep retries them. The current sweep excludes the ids it already kept, so it still never retries a failed delete within one sweep (same as before)Type of Change
Testing
staging.integration.tscase pinsDateso both sweeps start in the same millisecond. It fails on the old code and passes with the fix (local Postgres + Redis, single file, 7/7)Checklist
test-auditauthoring gate)