Repository navigation
chore(scripts): enforce generate/check pairs and regenerate every artifact with bun run generate - #10254
Merged
Conversation
…ifact with bun run generate
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge, with all three previous findings addressed. SummaryAdds shared generator discovery and an audit for generate/check pairs. Registers docs and schema-mock generation and updates contributor guidance.
Reviews (2) · Last reviewed commit: "fix(scripts): order docs before deployme..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
Review completed against the latest diff
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…sh regenerate on a clean tree
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check:generators(runs incheck:audits): everygenerate:<x>needs acheck:<x>, everycheck:<x>that runs a generator in check mode needs agenerate:<x>, and no test may rewrite a committed artifact behind anUPDATE_*env flagscripts/generators.ts, shared bybun run generateand the audit, so a new pair is picked up by both with nothing to listgenerate:docs(integration docs, one section per tool, already enforced bycheck:docs) andgenerate:schema-mock; drop the duplicateapps/simgenerate-docsscriptbun run generatenow covers all 15 repo-local generators in ~10s; when the working tree is exactly the pushed commit, the pre-push hook runs it and stops the push if it rewrites a tracked file (with uncommitted work it defers to CI'scheck:audits)bun run generate/generate:<x>Type of Change
Testing
bun run check:generatorsfails on the pre-change scripts (flagscheck:docsandcheck:schema-mockwith no generator) and passes afterscripts/generators.test.ts(7 passed)bun run generate(15 generators, exit 0, no drift); pushed through the new pre-push stepcheck:skills,check:schema-mock,check:sdk-fixture-catalog,check:script-tests,check:guidance-refs,check:comment-hygieneChecklist
test-auditauthoring gate)