Repository navigation
improvement(ci): start http e2e jobs beside the e2e build - #10244
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryHTTP e2e jobs now prepare their runners alongside
Reviews (2) · Last reviewed commit: "fix(ci): bound the wait-script test's ch..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build (e2e)instead of after it. Checkout, install, service containers and migrations overlap the build, then the job waits for the build artifact.github/scripts/wait-for-e2e-build.shpolls this run'sbuild (e2e)job and fails as soon as the build fails, is cancelled or skipped. It also fails on a missing or duplicated build job, or on any API error (no retry)checksgetsactions: readfrom both callers so the wait can read the run's jobsBefore (148 PR runs): wall p50 559s / p95 1151s. e2e setup on hosted runners: p50 65s / p95 ~90s. In 22 of 44 full runs the critical path ends in an HTTP e2e job.
Type of Change
Testing
scripts/wait-for-e2e-build.test.tsruns the real script against aghstub covering: success after polling, an unprefixed job name, failure/cancelled/skipped/timed_out, zero and two build jobs, and an API error. Each guard was reverted in turn and its tests went redcheck:script-tests,check:comment-hygieneChecklist
test-auditauthoring gate)