Skip to content

improvement(ci): start http e2e jobs beside the e2e build - #10244

Merged
waleedlatif1 merged 2 commits into
stagingfrom
ci/speed-round2
Nov 20, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
ci/speed-round2

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • HTTP e2e jobs now start beside build (e2e) instead of after it. Checkout, install, service containers and migrations overlap the build, then the job waits for the build artifact
  • .github/scripts/wait-for-e2e-build.sh polls this run's build (e2e) job and fails as soon as the build fails, is cancelled or skipped. It also fails on a missing or duplicated build job, or on any API error (no retry)
  • checks gets actions: read from both callers so the wait can read the run's jobs
  • The job timeout goes 20 → 24 min. The wait now happens inside the job, and four minutes covers it at the build's p95, so the suite keeps the same time budget as before

Before (148 PR runs): wall p50 559s / p95 1151s. e2e setup on hosted runners: p50 65s / p95 ~90s. In 22 of 44 full runs the critical path ends in an HTTP e2e job.

Type of Change

  • Improvement

Testing

  • scripts/wait-for-e2e-build.test.ts runs the real script against a gh stub covering: success after polling, an unprefixed job name, failure/cancelled/skipped/timed_out, zero and two build jobs, and an API error. Each guard was reverted in turn and its tests went red
  • shellcheck and actionlint on the changed files; check:script-tests, check:comment-hygiene
  • After numbers come from this PR's own run

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 20, 2026 7:07pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

HTTP e2e jobs now prepare their runners alongside build (e2e), then wait before downloading the build.

  • HTTP end-to-end jobs prepare while the production build runs.

Reviews (2) · Last reviewed commit: "fix(ci): bound the wait-script test's ch..." · Reviewed by Greptile

Comment thread scripts/wait-for-e2e-build.test.ts Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 170279a into staging Nov 20, 2026
78 checks passed
@waleedlatif1
waleedlatif1 deleted the ci/speed-round2 branch November 20, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant