Skip to content

fix(desktop): fix the races behind retried e2e checks and stop retrying in CI - #10235

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/desktop-e2e-no-retries
Nov 20, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/desktop-e2e-no-retries

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • apps/desktop/playwright.config.ts retried every failed check once in CI. 4 of the last 25 green desktop e2e runs only passed on that retry, so real failures were reported green. This removes the retry (Playwright default: 0) after fixing the three races behind them
  • Leave-page modal never took the keyboard (product bug): when a reload or navigation the user started holds the beforeunload decision, keyboard focus stayed in the native page view the modal hides, so Escape and Enter never reached the modal. holdPageDialogForUser now focuses the shell; answering already returns focus to the page. This failed Stay toBeFocused() in browser-page-dialogs.spec.ts (2 of the 4 runs)
  • Dialog answer helper raced the modal (test bug): panelAction('respond-dialog') picked modal vs bridge from an instant getByRole('dialog').count(). The store holds the dialog before its modal finishes the native-surface handshake, so the count could be 0, the helper fell through to clicking the heading, and by then the modal's visually hidden heading was the only one, so the click hung for 30s. It now branches on the store's current dialog, and Playwright's click waits for the modal
  • Drag started while the panel was still animating (test bug): switching to a chat with no saved width animates the panel to its 720px default. Every other chat switch in chat-panel.spec.ts waits for the settled width before dragging; the two pending:* switches did not, so the pointer could go down where the divider used to be

Type of Change

  • Bug fix

Testing

  • session.test.ts (73 tests), desktop tsc, biome on the changed files
  • Desktop e2e runs in this PR's CI with no retries; I'm re-running it several times to confirm the three checks hold

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 20, 2026 6:18am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

This PR fixes keyboard focus for leave-page dialogs and removes desktop E2E retries in CI.

  • Leave-page prompts receive keyboard focus when navigation is held.
  • Desktop e2e checks wait for dialogs and panel animations before acting.
  • Desktop CI reports failed e2e checks without retrying them.

No actionable issues were found. Review was based on source inspection; tests were not run.

Reviews (1) · Last reviewed commit: "fix(desktop): fix the races behind retri..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit a8d591e into staging Nov 20, 2026
50 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/desktop-e2e-no-retries branch November 20, 2026 06:22

This branch was previously deployed

1 inactive deployment
Preview — 36fdb344 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant