Repository navigation
fix(desktop): fix the races behind retried e2e checks and stop retrying in CI - #10235
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryThis PR fixes keyboard focus for leave-page dialogs and removes desktop E2E retries in CI.
No actionable issues were found. Review was based on source inspection; tests were not run. Reviews (1) · Last reviewed commit: "fix(desktop): fix the races behind retri..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/desktop/playwright.config.tsretried every failed check once in CI. 4 of the last 25 green desktop e2e runs only passed on that retry, so real failures were reported green. This removes the retry (Playwright default: 0) after fixing the three races behind themholdPageDialogForUsernow focuses the shell; answering already returns focus to the page. This failedStaytoBeFocused()inbrowser-page-dialogs.spec.ts(2 of the 4 runs)panelAction('respond-dialog')picked modal vs bridge from an instantgetByRole('dialog').count(). The store holds the dialog before its modal finishes the native-surface handshake, so the count could be 0, the helper fell through to clicking the heading, and by then the modal's visually hidden heading was the only one, so the click hung for 30s. It now branches on the store's current dialog, and Playwright's click waits for the modalchat-panel.spec.tswaits for the settled width before dragging; the twopending:*switches did not, so the pointer could go down where the divider used to beType of Change
Testing
session.test.ts(73 tests), desktoptsc, biome on the changed filesChecklist
test-auditauthoring gate)