Skip to content

improvement(hooks): check only changed files and affected workspaces before push - #10233

Merged
waleedlatif1 merged 2 commits into
stagingfrom
ci/pre-push-changed-files
Nov 20, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
ci/pre-push-changed-files

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • .husky/pre-push ran repo-wide lint:check plus the full type-check on every push
  • Now it diffs against the merge base with origin/staging and runs biome format + lint on the changed files, then turbo run type-check --affected (plus the scripts type-check when scripts/ changed)
  • Falls back to the full run when origin/staging is missing; CI still runs the full lint, type-check and audit gate on every PR

Type of Change

  • Improvement

Testing

Ran the hook locally against small diffs:

  • Hook-only change: passes in 1.4s (0 files checked, no workspace affected)
  • Format error + unused variable in apps/extension/src/background.ts: fails in biome (0.2s)
  • Type error alone in the same file: biome passes, @sim/extension#type-check fails with TS2322 (1.3s total)

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 20, 2026 6:19am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread .husky/pre-push Resolved
@greptile-apps

greptile-apps Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

Updates .husky/pre-push to check changed files and affected workspaces.

  • The pre-push hook checks changed files and affected workspaces.

Reviews (2) · Last reviewed commit: "fix(hooks): check the pushed commit and ..." · Reviewed by Greptile

Comment thread .husky/pre-push Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit d0dc01c into staging Nov 20, 2026
77 checks passed
@waleedlatif1
waleedlatif1 deleted the ci/pre-push-changed-files branch November 20, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant