Repository navigation
improvement(hooks): check only changed files and affected workspaces before push - #10233
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Contributor
[Medium impact] The PR appears safe to merge; no new actionable issues were found. SummaryUpdates
Reviews (2) · Last reviewed commit: "fix(hooks): check the pushed commit and ..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.husky/pre-pushran repo-widelint:checkplus the fulltype-checkon every pushorigin/stagingand runs biome format + lint on the changed files, thenturbo run type-check --affected(plus the scripts type-check whenscripts/changed)origin/stagingis missing; CI still runs the full lint, type-check and audit gate on every PRType of Change
Testing
Ran the hook locally against small diffs:
apps/extension/src/background.ts: fails in biome (0.2s)@sim/extension#type-checkfails with TS2322 (1.3s total)Checklist
test-auditauthoring gate)