Repository navigation
fix(executor): selected outputs no longer fail runs that call a child workflow - #10232
Merged
Merged
Conversation
… workflow A sync run handed the caller's public `block.path` selectors to the executor instead of the internal form it had already resolved, so the child-workflow block parsed `done.data` as workflow `done`, block `data` and failed the run after it executed and billed. The v2 execute service and the v1 sync path now pass resolved selectors (v1 drops ones naming no block, as it always ignored them), and the child-workflow block drops a selector it cannot apply with a warning rather than failing the block.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryConverts sync output selections before passing them to the executor. Child workflows now ignore selections they cannot serve instead of failing an admitted run.
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
… outputs A child-workflow selector was admitted on a synchronous run but the response projection only read parent block logs, so its key was silently missing from blockOutputs. Read the child block's output from the trace spans its workflow block carried back, matching by block ID or normalized name.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sim workflows run --select-output done.data(and any sync execute withselectedOutputs) failed the whole run, after it executed and billed, whenever the workflow contained a child-workflow block:Nested output selector is missing its output path: done.data.Cause: the sync path in
executeWorkflowServicevalidated and converted selectors to the executor's internal form, then built the snapshot from the caller's raw selectors. The child-workflow block parses internal-form selectors, readdone.dataas workflowdone, blockdata, no path, and threw mid-run. The v1 execute route's non-SSE sync path never converted selectors at all.Fix
selectChildOutputSelectorsnever throws: parent selectors are skipped, deeper ones passed on, child ones translated; unparseable/unknown ones are returned asignoredand logged.Tests: new integration test (real Postgres) through
executeWorkflowOperationwith a deployed parent → child workflow → response; fails without the fix. Unit test for the child-side tolerance alone.🤖 Generated with Claude Code