Skip to content

fix(redaction): redact sensitive table rows in logged inputs - #10221

Open
grapestore wants to merge 1 commit into
simstudioai:stagingfrom
grapestore:fix/redact-sensitive-table-rows
Open

grapestore wants to merge 1 commit into
simstudioai:stagingfrom
grapestore:fix/redact-sensitive-table-rows

Conversation

@grapestore

Copy link
Copy Markdown

Summary

Table sub-blocks (such as the API block's Headers and Query Params) store each row as { cells: { Key, Value } }. redactApiKeys only matches object keys, so a header named Authorization is a cell value it never sees, and a token typed into the API block's Headers table is persisted in plain text in the block's logged input.

This adds one branch to redactApiKeys: when a cells object has a string Key that isSensitiveKey matches, its Value is replaced with [REDACTED]. Other rows and the existing key-based redaction are unchanged.

Secrets referenced through {{NAME}} are already covered by the resolved-secret trace projection. This covers values typed directly into a table.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: ___________

Testing

  • bun vitest run lib/core/security/redaction.test.ts: 88 passed, including 3 new tests. The sensitive-row test fails without the change.
  • bun vitest run lib/core/security lib/logs executor/execution: 1351 passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Table sub-blocks store each row as { cells: { Key, Value } }, so a header
named Authorization is a cell value and key-based redaction never saw it.
Redact the Value of rows whose Key is a sensitive name.

Signed-off-by: inkyu-bae <inkyu.bae@navercorp.com>
@vercel

vercel Bot commented Nov 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 20, 2026 2:21am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 3/5

[Medium impact] The change reaches several logging and preview paths that share the redactor.

Preserve recursive redaction of extra cell fields before merging.

Findings

  1. P1 Security Extra secrets escape redaction ▶

Summary

Adds table-row redaction to redactApiKeys.

  • Sensitive table rows now hide their values in logged copies.

Reviews (1) · Last reviewed commit: "fix(redaction): redact sensitive table r..." · Reviewed by Greptile

Comment on lines +512 to +513
} else if (isSensitiveTableCells(key, value)) {
result[key] = { ...value, Value: REDACTED_MARKER }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 security Extra secrets escape redaction

The new branch skips recursive redaction for every field beside Value. redactApiKeys also receives arbitrary JSON from block inputs and workflow outputs, not just two-column tables. For example, {"cells":{"Key":"Authorization","Value":"token","password":"secret"}} now leaves password in plain text in logs; previously it was redacted. Nested secrets beside Value also escape.

Recursively redact the copied cells before replacing Value, and add a regression test for an extra sensitive field.

How this was verified: Block inputs are parsed as JSON and passed to redactApiKeys, where the new shallow copy preserves sensitive sibling fields instead of visiting them.

This branch was previously deployed

1 inactive deployment
Preview — 710a1141 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant