Skip to content

fix(search): say a Slack file hit can return its full text rather than promising it - #10123

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/slack-file-hit-wording
Nov 17, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/slack-file-hit-wording

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • A Slack file hit no longer promises "Reading it returns its full text." A read of a supported type under the download limit can still fall back to Slack's preview (scanned or encrypted PDFs, PDFs past the page limit, extracted text past its cap, an unreported size, a slow or refused download), so the hit now says "Reading it can return its full text." The read itself is unchanged and still names the reason when it returns the preview.
  • "Too large to read in full here" and "The file is empty." stay as they are; both are exact.

Type of Change

  • Bug fix

Testing

  • bunx vitest run lib/sim-search/live/providers.test.ts lib/sim-search/live/slack.test.ts (51 passed), lint

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 17, 2026 7:02am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This wording-only change appears safe to merge.

Summary

Slack file hits now say reading “can return” full text instead of promising it.

  • Slack file hits say a read can return full text.

Reviews (1) · Last reviewed commit: "fix(search): say a Slack file hit can re..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 263b3eb into staging Nov 17, 2026
60 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/slack-file-hit-wording branch November 17, 2026 07:04

This branch was previously deployed

1 inactive deployment
Preview — 31b845bd Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant