Skip to content

improvement(ci): scope reviewed root audits to their checks - #10121

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/ci-article-refinements
Nov 17, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/ci-article-refinements

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Keep edits limited to the reviewed library-content and utils-enforcement auditors on the always-on lint/audit gate and the complete root script suite.
  • Avoid unrelated application builds, databases and browser jobs for those audit-only changes.
  • Preserve full validation for mixed changes, deleted or moved inputs, unknown scripts, CI changes and unusable comparison/provenance. Push validation remains full.

Type of Change

  • Other: CI efficiency

Testing

  • Hosted pre-change regression: two intended failures demonstrate the previous full-suite fallback for audit-only edits.
  • Hosted fixed planner: all 73 real Git/Turbo ownership cases pass.
  • Three deliberately broken admission guards fail their expected retained cases: deleted owner (1), mixed owner (3), script dispatch (2).
  • Full hosted PR checks pass; the planner change itself retains full selection. No local builds or test suites ran.
  • Same-head audit-only control: 4 allocated jobs and 124s versus 44 jobs and 341s with full fallback. Always-on audits and the complete root script suite remain selected.
  • A deliberately broken browser-runtime audit fails exactly two existing root tests and the aggregate CI gate on the narrowed path.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing in full hosted CI
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 17, 2026 6:38am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

Scopes changes limited to four reviewed audit files to lint/audits and the complete root script test suite.

  • Audit-only edits now run lint and root script tests without app jobs.

Reviews (2) · Last reviewed commit: "chore(ci): clarify audit-only runner all..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread .github/CI.md Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 9a8b002 into staging Nov 17, 2026
83 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/ci-article-refinements branch November 17, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant