Repository navigation
improvement(search): describe Slack file hits and leave out GitLab sources that grant the reader nothing - #10120
Conversation
…urces that grant the reader nothing
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR appears safe to merge; no new actionable issues were found. SummarySlack file hits now describe the file type, size, and read limits. GitLab sources with no CSV grant for the reader are left out of searches.
Reviews (3) · Last reviewed commit: "fix(search): redact the GitLab grant-che..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
… fail GitLab source filtering open
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
Type of Change
Testing
lib/knowledge/__integration__/gitlab-group.integration.ts(real Postgres + HTTP GitLab fixture): new case — a reader whose CSV grant was revoked no longer sees that source while another reader still sees both; red with the listing filter removed, green with it (11/11)lib/sim-search/live/providers.test.ts: new Slack file-hit cases; red against the old title echo, green afterbunx vitest run lib/sim-search/live/(474 tests),bun run lint; full type-check and audits run in CIChecklist
test-auditauthoring gate)