Skip to content

improvement(search): describe Slack file hits and leave out GitLab sources that grant the reader nothing - #10120

Merged
waleedlatif1 merged 3 commits into
stagingfrom
improvement/search-file-hits-and-gitlab-access
Nov 17, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
improvement/search-file-hits-and-gitlab-access

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Slack Real-time Search returns only a file's title for a file hit (repeated as its content), so agents saw a bare filename and skipped readable files. Each file hit now says what the file is (Canvas, List, PDF, Word, CSV, Image…), its size when Slack reports it, and whether reading it returns its full text — reusing the workspace-files type labels and the same readability check the Slack read path uses. Text Slack returns beyond the title is kept. No extra Slack requests per hit.
  • An admin-managed GitLab source in CSV permission mode that grants the reader no project is now left out of their live search accounts instead of reporting "not available to your account" on every search (which also marked every search partial). Sources checked against GitLab itself, and any whose stored permissions can't be read, stay listed; a failed identity lookup lists every source. The session's grant check is unchanged and still enforces access.
  • Tool descriptions are unchanged, so connected clients aren't asked to re-approve the connector.

Type of Change

  • Improvement

Testing

  • lib/knowledge/__integration__/gitlab-group.integration.ts (real Postgres + HTTP GitLab fixture): new case — a reader whose CSV grant was revoked no longer sees that source while another reader still sees both; red with the listing filter removed, green with it (11/11)
  • lib/sim-search/live/providers.test.ts: new Slack file-hit cases; red against the old title echo, green after
  • bunx vitest run lib/sim-search/live/ (474 tests), bun run lint; full type-check and audits run in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 17, 2026 6:51am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

Slack file hits now describe the file type, size, and read limits. GitLab sources with no CSV grant for the reader are left out of searches.

  • Slack file hits say what the file is and whether its text can be read.
  • GitLab search leaves out sources that grant a member no project.

Reviews (3) · Last reviewed commit: "fix(search): redact the GitLab grant-che..." · Reviewed by Greptile

Comment thread apps/sim/lib/sim-search/live/slack.ts Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/lib/sim-search/live/slack.ts Resolved
Comment thread apps/sim/lib/sim-search/live/slack.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 9 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/lib/sim-search/live/slack.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit cf81937 into staging Nov 17, 2026
62 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/search-file-hits-and-gitlab-access branch November 17, 2026 06:54

This branch was previously deployed

1 inactive deployment
Preview — 47e4bd4a Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant