Skip to content

fix(search): validate GitLab group scope before permission refresh - #10117

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/gitlab-group-refresh-scope
Nov 17, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/gitlab-group-refresh-scope

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Reject GitLab group CSV refreshes that no longer match the saved source path, before changing permissions. Reuse the scope validation already applied during live Search.
  • Preserve valid same-ID group rename refreshes for numeric-ID connections, and clarify group limits and rename setup in the docs.

Type of Change

  • Bug fix

Testing

  • Reproduced the stale-path refresh failure before the fix; the numeric-ID compatibility case passed on both versions.
  • 10 real-PostgreSQL/HTTP-fixture integration checks passed, including permission isolation, legacy source preservation, atomic updates, and renamed-group search/read.
  • 53 focused tests passed. Lint, type-check, audits, and test-type checks validated locally; full suites run in CI.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 17, 2026 4:15am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

This PR checks the saved GitLab group scope before replacing CSV permissions.

  • GitLab group permission refreshes reject paths that no longer match the saved scope.
  • GitLab group setup docs explain the project limit and rename steps.

No actionable issues found. Tests were inspected but not run.

Reviews (1) · Last reviewed commit: "fix(search): validate GitLab group scope..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 1b9fdd9 into staging Nov 17, 2026
84 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/gitlab-group-refresh-scope branch November 17, 2026 06:07

This branch was successfully deployed

1 active deployment
Preview — a778a926 Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant