Repository navigation
fix(computer-use): find a save panel control's window through its ancestors when it reports none - #10116
Merged
Conversation
…estors when it reports none
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The change appears safe to merge; the parent lookup preserves the existing window and focus checks. Summary
Reviews (1) · Last reviewed commit: "fix(computer-use): find a save panel con..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AXWindow(System Events returnsmissing value), even though its parent chain is field → AXSheet → the app's windowcontainingWindowused only that attribute, so typing into a save panel's file-name field was refused withstale_window("The editor's window moved or is not an observed window") although the panel sat in the observed windowcontainingWindownow uses its nearest window or sheet ancestor (bounded at 64 levels). The sheet then goes through the existingacceptsInputrule (its owner must be an observed window at the observed frame), so nothing is loosened; the same fallback reaches window lookup and click hit-testing for panel controlsType of Change
Testing
type_textinto the file-name field, no model calls): current staging returnsstale_windowwithdispatchState: not_started; this branch types successfullytests/live.pypasses on this branch's helper (window-target typing, title-bar click, batch stopping when a sheet opens); native tests pass; CI desktop jobs compile the helperChecklist