Skip to content

fix(computer-use): find a save panel control's window through its ancestors when it reports none - #10116

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/computer-use-remote-panel-window
Nov 17, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/computer-use-remote-panel-window

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Controls in an open or save panel belong to the panel's service process, and the file-name field reports no AXWindow (System Events returns missing value), even though its parent chain is field → AXSheet → the app's window
  • containingWindow used only that attribute, so typing into a save panel's file-name field was refused with stale_window ("The editor's window moved or is not an observed window") although the panel sat in the observed window
  • When an element reports no window, containingWindow now uses its nearest window or sheet ancestor (bounded at 64 levels). The sheet then goes through the existing acceptsInput rule (its owner must be an observed window at the observed frame), so nothing is loosened; the same fallback reaches window lookup and click hit-testing for panel controls

Type of Change

  • Bug fix

Testing

  • On a GUI-only run of 26 native macOS tasks, typing a file name into a save panel failed this way in Contacts' vCard export, Preview's save and LibreOffice's save-as
  • Probe in fresh macOS VMs (Contacts → File → Export → Export vCard…, then type_text into the file-name field, no model calls): current staging returns stale_window with dispatchState: not_started; this branch types successfully
  • tests/live.py passes on this branch's helper (window-target typing, title-bar click, batch stopping when a sheet opens); native tests pass; CI desktop jobs compile the helper

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 17, 2026 3:40am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The change appears safe to merge; the parent lookup preserves the existing window and focus checks.

Summary

containingWindow now checks up to 64 parents when a control reports no window. This lets save-panel fields reach the existing checks for their sheet’s owning window.

  • Controls without a window now find the nearest window or sheet above them.

Reviews (1) · Last reviewed commit: "fix(computer-use): find a save panel con..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 4a30494 into staging Nov 17, 2026
50 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/computer-use-remote-panel-window branch November 17, 2026 06:07

This branch was previously deployed

1 inactive deployment
Preview — 47f55b00 Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant