Repository navigation
fix(library): attribute sim counts by clause and table row, not capitalized words - #10115
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR appears safe to merge, with no outstanding findings. SummaryUpdates
Reviews (10) · Last reviewed commit: "docs(library): describe sim-count table ..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
3 issues found across 2 files
Confidence score: 3/5
- In
scripts/check-library-content.ts, the, which/, whosplit can detach a relative clause about Sim when it follows a non-Sim noun, leaving Sim’s count unattributed. Keep the clause attached unless the preceding subject is Sim. - In
scripts/check-library-content.ts, replacing the delimiter can attribute a competitor’s relative-clause count to Sim. Preserve the delimiter when splitting the sentence. - In
scripts/check-library-content.ts, valid GFM table rows without a leading|bypass row classification, so competitor counts can be treated as Sim’s. Recognize rows without requiring that leading pipe.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="scripts/check-library-content.ts">
<violation number="1" location="scripts/check-library-content.ts:156">
P2: The `, which` / `, who` clause break also fires after non-Sim nouns, so a relative clause about Sim is split off and its count goes unattributed. "Sim is an AI workspace, which connects to 1,000+ integrations" passes. Only split on `, which|who` when the referent is another product, or drop the relative-clause break and rely on the contrast and sentence breaks.</violation>
<violation number="2" location="scripts/check-library-content.ts:177">
P2: This replacement erases the delimiter needed to separate a competitor’s relative clause, so `Sim has 280+ integrations, unlike Zapier, which has 9,000+ integrations` incorrectly validates Zapier’s count as Sim’s. Preserve the clause boundary and handle product names containing digits such as `n8n`.</violation>
<violation number="3" location="scripts/check-library-content.ts:192">
P2: Valid GFM rows without a leading `|` bypass the table-row classifier. A competitor row such as `n8n | Alternative to Sim | 2,000+ integrations |` then enters prose attribution and is falsely treated as Sim’s count; recognize both table forms or parse table structure before attributing counts.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
67603e5 to
dee23a4
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
… clauses, prefixes, and linked names in sim-count
…l comparisons to sim, and detect pipe-less table rows
…keep counted openers
…stead of deleting them
…ount lists together, and end sentences before closing quotes
…ct and tell count lists from new clauses
6f89fa6 to
168317b
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
… digit product names as new subjects
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
sim-countattributed a count to Sim only when no capitalized word sat between "Sim" and the number, within 12 words. That skipped real Sim claims such as "Sim combines Chat with 270+ integrations", "Sim's Agent blocks … connect to 270+ integrations", and| Sim | … | 270+ integrations |table rows, so an overclaim written that way would pass. It checked 19 of the library's Sim count claims.Type of Change
Testing
scripts/check-library-content.test.ts: new reject cases (linked product name, mid-clause capitals, plain and linked Sim table rows) and accept cases ("Unlike Sim, …", "Like Sim, …", "…, while Zapier lists …", "fewer than Zapier's …", a competitor table row, a count before the Sim mention). Each fails with its guard reverted.bun run test:scripts(773 tests) andbun run check:library-content(204 posts) pass.Checklist
test-auditauthoring gate)